public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Joe Perches <joe@perches.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Venu Byravarasu <vbyravarasu@nvidia.com>
Subject: Re: [PATCH 2/5] mfd: tps65090: add error prints when mem alloc failed
Date: Mon, 8 Oct 2012 11:33:11 +0530	[thread overview]
Message-ID: <50726C9F.1030502@nvidia.com> (raw)
In-Reply-To: <1349626414.15802.2.camel@joe-AO722>

On Sunday 07 October 2012 09:43 PM, Joe Perches wrote:
> On Sun, 2012-10-07 at 20:52 +0530, Laxman Dewangan wrote:
>> Add error prints when memory allocation failed for
>> tps65090 data. Also cleanups the melloc arguments.
> The new dev_err is unnecessary.
> A dump_stack is already done on alloc failures.
> The sizeof(* is ok.
>

I think this will also prints the device name for which it fails and so 
when we have multiple device, it will help to find out the failure case.

Thanks,
Laxman

  reply	other threads:[~2012-10-08  6:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-07 15:22 [PATCH 0/5] mfd: tps65090: cleanups and use regmap-irq for interrupt support Laxman Dewangan
2012-10-07 15:22 ` [PATCH 1/5] mfd: add battery charger in tps65090 sub devs Laxman Dewangan
2012-10-07 15:22 ` [PATCH 2/5] mfd: tps65090: add error prints when mem alloc failed Laxman Dewangan
2012-10-07 16:13   ` Joe Perches
2012-10-08  6:03     ` Laxman Dewangan [this message]
2012-10-07 15:22 ` [PATCH 3/5] mfd: tps65090: remove unused member of struct tps65090 Laxman Dewangan
2012-10-08  5:40   ` Venu Byravarasu
2012-10-08  5:55     ` Laxman Dewangan
2012-10-07 15:22 ` [PATCH 4/5] mfd: tps65090: move register access APIs to header Laxman Dewangan
2012-10-08  5:37   ` Venu Byravarasu
2012-10-08  5:55     ` Laxman Dewangan
2012-10-07 15:22 ` [PATCH 5/5] mfd: tps65090: use regmap irq framework for interrupt support Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50726C9F.1030502@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=vbyravarasu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox