From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
peterz@infradead.org, fweisbec@gmail.com,
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
Dong Hao <haodong@linux.vnet.ibm.com>
Subject: Re: [PATCH 12/12] perf kvm: add live mode
Date: Mon, 08 Oct 2012 14:54:10 -0600 [thread overview]
Message-ID: <50733D72.9010100@gmail.com> (raw)
In-Reply-To: <20121008203534.GF2631@ghostprotocols.net>
On 10/8/12 2:35 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 08, 2012 at 11:17:36AM -0600, David Ahern escreveu:
> Overall it looks good, I like the fact you're not doing it the way perf
> script does, i.e. that "pipe mode" thing, more or less like I'm doing on
> 'perf trace', but I think this is the time to get rid of 'perf_session'
> too for this specific "live mode" tools.
pipe mode would never work for this case. I'm looking at nested virt
case now and it shows 360,000 events per second.
> I'm almost getting there for 'trace' and 'top', just need to move the
> ordered_samples code to evlist, then session, top, trace, kvm live and
> script will not need to use 'perf_session' at all.
ok. you going to have that soon?
> Also that 'perf_kvm__open_counters' really is just a third copy of code
> in 'record' and 'top', right? You could move it to
> 'perf_ev{list,open}__open' and solve this dup :-)
there's a TO-DO at the top of that function for that reason ;-) I copied
a fair bit from perf-stat. Now that it's working I can look at code
consolidation.
> I applied the cleanups/simple stuff, will try to do some of the prep
> work on ordered_samples to use on top and trace and then I think you
> could look there so that we get to something that is useful for all
> these !perf.data tools.
On my Westmere based server I am not seeing problems with timestamps and
ordering (prior testing was on a Nehalem based server). It just
weathered a 5 minute or so barrage of > 100,000 events per second
(peaking at around 360k events/sec) with no problem.
David
next prev parent reply other threads:[~2012-10-08 20:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 17:17 [PATCH 00/12] perf kvm: Add live mode for analyzing events David Ahern
2012-10-08 17:17 ` [PATCH 01/12] perf evlist: restore some methods removed in an earlier cleanup David Ahern
2012-10-08 17:17 ` [PATCH 02/12] perf evlist: move tracepoint processing code to evlist.c David Ahern
2012-10-08 17:17 ` [PATCH 03/12] perf evlist: add initialzation function for tracepoints David Ahern
2012-10-08 17:17 ` [PATCH 04/12] perf session: export a few functions for event processing David Ahern
2012-10-08 17:17 ` [PATCH 05/12] perf top: move CONSOLE_CLEAR to header file David Ahern
2012-10-08 17:17 ` [PATCH 06/12] perf kvm: remove typecast in init_kvm_event_record David Ahern
2012-10-09 17:38 ` [tip:perf/core] perf kvm: Remove " tip-bot for David Ahern
2012-10-08 17:17 ` [PATCH 07/12] perf kvm: handle realloc failures David Ahern
2012-10-08 20:19 ` Arnaldo Carvalho de Melo
2012-10-08 20:34 ` David Ahern
2012-10-08 21:38 ` Arnaldo Carvalho de Melo
2012-10-08 17:17 ` [PATCH 08/12] perf kvm: add braces around multi-line statements David Ahern
2012-10-09 17:40 ` [tip:perf/core] perf kvm: Add " tip-bot for David Ahern
2012-10-08 17:17 ` [PATCH 09/12] perf kvm: split out tracepoints from record args David Ahern
2012-10-17 8:19 ` Xiao Guangrong
2012-10-17 13:38 ` David Ahern
2012-10-08 17:17 ` [PATCH 10/12] perf kvm: total count is a u64, print as so David Ahern
2012-10-09 17:39 ` [tip:perf/core] perf kvm: Total " tip-bot for David Ahern
2012-10-08 17:17 ` [PATCH 11/12] perf kvm: only process events for vcpus of interest David Ahern
2012-10-09 17:37 ` [tip:perf/core] perf kvm: Only " tip-bot for David Ahern
2012-10-08 17:17 ` [PATCH 12/12] perf kvm: add live mode David Ahern
2012-10-08 20:35 ` Arnaldo Carvalho de Melo
2012-10-08 20:54 ` David Ahern [this message]
2012-10-08 21:44 ` Arnaldo Carvalho de Melo
2012-10-08 21:57 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50733D72.9010100@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=haodong@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).