Re: [PATCH 0/5] efivarfs: fixes and cleanups

Matt Fleming
2012-10-11T12:49:11Z

On Thu, 2012-10-11 at 11:32 +0100, Andy Whitcroft wrote:
> We have recently been looking to backport the efivarfs support as posted,
> to 3.5.x. Inspired by some searching questions from Tetsuo Handa I have
> been reviewing this code. The following a first pass at fixing up some
> of the error handling. As they represent error paths they are hard to
> truly verify so deserve review.
>
> On top of 7b218e8e5d433fc8b531ce911926e06de3e6f1f6 in Matt Flemmings efi.git
> repo.
>
> -apw
>
> Andy Whitcroft (5):
> efivarfs: efivarfs_file_read ensure we free data in error paths
> efivarfs: efivarfs_create() ensure we drop our reference on inode on error
> efivarfs: efivarfs_fill_super() fix inode reference counts
> efivarfs: efivarfs_fill_super() ensure we free our temporary name
> efivarfs: efivarfs_fill_super() ensure we clean up correctly on error
>
> drivers/firmware/efivars.c | 56 +++++++++++++++++++++++++++-----------------
> 1 file changed, 35 insertions(+), 21 deletions(-)

Thanks Andy, I've added Matthew's Acked-by and applied this series to my
'next' branch.