From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759102Ab2JKSWe (ORCPT ); Thu, 11 Oct 2012 14:22:34 -0400 Received: from oproxy11-pub.bluehost.com ([173.254.64.10]:36784 "HELO oproxy11-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756379Ab2JKSWb (ORCPT ); Thu, 11 Oct 2012 14:22:31 -0400 Message-ID: <50770E5C.4040302@xenotime.net> Date: Thu, 11 Oct 2012 11:22:20 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9 MIME-Version: 1.0 To: Nishanth Menon CC: linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Kevin Hilman , MyungJoo Ham , Kyungmin Park , linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM / devfreq: kernel-doc typo corrections References: <1349962755-19598-1-git-send-email-nm@ti.com> In-Reply-To: <1349962755-19598-1-git-send-email-nm@ti.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2012 06:39 AM, Nishanth Menon wrote: > Parameter documentation needs a ':' for scripts/kernel-doc > to parse properly. > > Minor fixes for ones warned by: > ./scripts/kernel-doc -text drivers/devfreq/devfreq.c>/dev/null > > Cc: "Rafael J. Wysocki" > Cc: Kevin Hilman > Cc: MyungJoo Ham > Cc: Kyungmin Park > Cc: linux-kernel@vger.kernel.org > Cc: linux-pm@vger.kernel.org > > Signed-off-by: Nishanth Menon Acked-by: Randy Dunlap Thanks. > --- > drivers/devfreq/devfreq.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 70c31d4..e4d48d2 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -123,9 +123,9 @@ int update_devfreq(struct devfreq *devfreq) > /** > * devfreq_notifier_call() - Notify that the device frequency requirements > * has been changed out of devfreq framework. > - * @nb the notifier_block (supposed to be devfreq->nb) > - * @type not used > - * @devp not used > + * @nb: the notifier_block (supposed to be devfreq->nb) > + * @type: not used > + * @devp: not used > * > * Called by a notifier that uses devfreq->nb. > */ > @@ -431,7 +431,7 @@ err_out: > > /** > * devfreq_remove_device() - Remove devfreq feature from a device. > - * @devfreq the devfreq instance to be removed > + * @devfreq: the devfreq instance to be removed > */ > int devfreq_remove_device(struct devfreq *devfreq) > { > @@ -641,9 +641,9 @@ module_exit(devfreq_exit); > /** > * devfreq_recommended_opp() - Helper function to get proper OPP for the > * freq value given to target callback. > - * @dev The devfreq user device. (parent of devfreq) > - * @freq The frequency given to target function > - * @flags Flags handed from devfreq framework. > + * @dev: The devfreq user device. (parent of devfreq) > + * @freq: The frequency given to target function > + * @flags: Flags handed from devfreq framework. > * > */ > struct opp *devfreq_recommended_opp(struct device *dev, unsigned long *freq, > @@ -674,8 +674,8 @@ struct opp *devfreq_recommended_opp(struct device *dev, unsigned long *freq, > * devfreq_register_opp_notifier() - Helper function to get devfreq notified > * for any changes in the OPP availability > * changes > - * @dev The devfreq user device. (parent of devfreq) > - * @devfreq The devfreq object. > + * @dev: The devfreq user device. (parent of devfreq) > + * @devfreq: The devfreq object. > */ > int devfreq_register_opp_notifier(struct device *dev, struct devfreq *devfreq) > { > @@ -690,8 +690,8 @@ int devfreq_register_opp_notifier(struct device *dev, struct devfreq *devfreq) > * devfreq_unregister_opp_notifier() - Helper function to stop getting devfreq > * notified for any changes in the OPP > * availability changes anymore. > - * @dev The devfreq user device. (parent of devfreq) > - * @devfreq The devfreq object. > + * @dev: The devfreq user device. (parent of devfreq) > + * @devfreq: The devfreq object. > * > * At exit() callback of devfreq_dev_profile, this must be included if > * devfreq_recommended_opp is used. -- ~Randy