* Re: [PATCH 1/3] Coccicheck: Add the rep+ctxt mode [not found] <CAAxaTiOsaHOR4cbwcq=xOn-sWxB6PdB4x_UgYf2rUsPQM=WwWA@mail.gmail.com> @ 2012-10-11 13:15 ` Michal Marek 2012-10-11 13:46 ` Nicolas Palix 0 siblings, 1 reply; 3+ messages in thread From: Michal Marek @ 2012-10-11 13:15 UTC (permalink / raw) To: Nicolas Palix; +Cc: Julia Lawall, linux-kernel On Thu, Sep 20, 2012 at 10:30:46PM +0200, Nicolas Palix wrote: > This adds a 'rep+ctxt' mode which prints the warning > message followed by the context. > > Signed-off-by: Nicolas Palix <nicolas.palix@imag.fr> > --- > scripts/coccicheck | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index 823e972..eb43e40 100755 > --- a/scripts/coccicheck > +++ b/scripts/coccicheck > @@ -95,6 +95,9 @@ coccinelle () { > $SPATCH -D report $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff || \ > $SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS || \ > $SPATCH -D org $FLAGS -sp_file $COCCI $OPT $OPTIONS > -no_show_diff || exit 1 Your mailer broke this line into two, please try to avoid this next time. Also, please CC lkml when submitting patches. I applied the patch to kbuild.git#misc now. Michal > + elif [ "$MODE" = "rep+ctxt" ] ; then > + $SPATCH -D report $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff && \ > + $SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS > || exit 1 > else > $SPATCH -D $MODE $FLAGS -sp_file $COCCI $OPT $OPTIONS || exit 1 > fi > -- > 1.7.11.3 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] Coccicheck: Add the rep+ctxt mode 2012-10-11 13:15 ` [PATCH 1/3] Coccicheck: Add the rep+ctxt mode Michal Marek @ 2012-10-11 13:46 ` Nicolas Palix 2012-10-11 20:15 ` Michal Marek 0 siblings, 1 reply; 3+ messages in thread From: Nicolas Palix @ 2012-10-11 13:46 UTC (permalink / raw) To: Michal Marek; +Cc: Julia Lawall, linux-kernel Hi, On Thu, Oct 11, 2012 at 3:34 PM, Michal Marek <mmarek@suse.cz> wrote: > On Thu, Sep 20, 2012 at 10:30:46PM +0200, Nicolas Palix wrote: >> This adds a 'rep+ctxt' mode which prints the warning >> message followed by the context. >> >> Signed-off-by: Nicolas Palix <nicolas.palix@imag.fr> >> --- >> scripts/coccicheck | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/scripts/coccicheck b/scripts/coccicheck >> index 823e972..eb43e40 100755 >> --- a/scripts/coccicheck >> +++ b/scripts/coccicheck >> @@ -95,6 +95,9 @@ coccinelle () { >> $SPATCH -D report $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff || \ >> $SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS || \ >> $SPATCH -D org $FLAGS -sp_file $COCCI $OPT $OPTIONS >> -no_show_diff || exit 1 > > Your mailer broke this line into two, please try to avoid this next > time. Also, please CC lkml when submitting patches. I applied the patch > to kbuild.git#misc now. Ooops.. Sorry. I didn't notice. The patches are publish on github in my coccicheck branch. https://github.com/npalix/linux/commits/coccicheck Do you prefer a pull request next time to avoid such things ? Nicolas > > Michal > >> + elif [ "$MODE" = "rep+ctxt" ] ; then >> + $SPATCH -D report $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff && \ >> + $SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS >> || exit 1 >> else >> $SPATCH -D $MODE $FLAGS -sp_file $COCCI $OPT $OPTIONS || exit 1 >> fi >> -- >> 1.7.11.3 -- Nicolas Palix ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] Coccicheck: Add the rep+ctxt mode 2012-10-11 13:46 ` Nicolas Palix @ 2012-10-11 20:15 ` Michal Marek 0 siblings, 0 replies; 3+ messages in thread From: Michal Marek @ 2012-10-11 20:15 UTC (permalink / raw) To: Nicolas Palix; +Cc: Julia Lawall, linux-kernel Dne 11.10.2012 15:46, Nicolas Palix napsal(a): > Hi, > > On Thu, Oct 11, 2012 at 3:34 PM, Michal Marek <mmarek@suse.cz> wrote: >> On Thu, Sep 20, 2012 at 10:30:46PM +0200, Nicolas Palix wrote: >>> This adds a 'rep+ctxt' mode which prints the warning >>> message followed by the context. >>> >>> Signed-off-by: Nicolas Palix <nicolas.palix@imag.fr> >>> --- >>> scripts/coccicheck | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/scripts/coccicheck b/scripts/coccicheck >>> index 823e972..eb43e40 100755 >>> --- a/scripts/coccicheck >>> +++ b/scripts/coccicheck >>> @@ -95,6 +95,9 @@ coccinelle () { >>> $SPATCH -D report $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff || \ >>> $SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS || \ >>> $SPATCH -D org $FLAGS -sp_file $COCCI $OPT $OPTIONS >>> -no_show_diff || exit 1 >> >> Your mailer broke this line into two, please try to avoid this next >> time. Also, please CC lkml when submitting patches. I applied the patch >> to kbuild.git#misc now. > > Ooops.. Sorry. I didn't notice. > > The patches are publish on github in my coccicheck branch. > https://github.com/npalix/linux/commits/coccicheck > > Do you prefer a pull request next time to avoid such things ? Yes, if you base the branch on some tagged release, preferably the latest -rc1. Michal ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-11 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAAxaTiOsaHOR4cbwcq=xOn-sWxB6PdB4x_UgYf2rUsPQM=WwWA@mail.gmail.com>
2012-10-11 13:15 ` [PATCH 1/3] Coccicheck: Add the rep+ctxt mode Michal Marek
2012-10-11 13:46 ` Nicolas Palix
2012-10-11 20:15 ` Michal Marek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox