From: Jens Axboe <axboe@kernel.dk>
To: Derek Basehore <dbasehore@chromium.org>
Cc: msb@chromium.org, spang@chromium.org, bfreed@chromium.org,
arscott@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Remove deadlock in disk_clear_events
Date: Fri, 12 Oct 2012 11:01:07 -0600 [thread overview]
Message-ID: <50784CD3.2040008@kernel.dk> (raw)
In-Reply-To: <1349992327-9747-1-git-send-email-dbasehore@chromium.org>
On 2012-10-11 15:52, Derek Basehore wrote:
> In disk_clear_events, do not put work on system_nrt_freezable_wq. Instead, put
> it on system_nrt_wq.
>
> There is a race between probing a usb and suspending the device. Since probing a
> usb calls disk_clear_events, which puts work on a frozen workqueue, probing
> cannot finish after the workqueue is frozen. However, suspending cannot finish
> until the usb probe is finished, so we get a deadlock.
Thanks, applied to later inclusion into 3.7. You did not mark this as
stable, though it seems it should be?
--
Jens Axboe
prev parent reply other threads:[~2012-10-12 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 21:52 [PATCH] block: Remove deadlock in disk_clear_events Derek Basehore
2012-10-12 17:01 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50784CD3.2040008@kernel.dk \
--to=axboe@kernel.dk \
--cc=arscott@chromium.org \
--cc=bfreed@chromium.org \
--cc=dbasehore@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
--cc=spang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox