From: Roland Stigge <stigge@antcom.de>
To: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04
Date: Mon, 15 Oct 2012 16:24:52 +0200 [thread overview]
Message-ID: <507C1CB4.7070203@antcom.de> (raw)
In-Reply-To: <1350305256-27295-1-git-send-email-aletes.xgr@gmail.com>
On 10/15/2012 02:47 PM, Alexandre Pereira da Silva wrote:
> The STOTG04 is an replacement for ISP1301.
>
> Most of the registers on STOTG04 are the same as on ISP1301, but the
> register ISP1301_I2C_OTG_CONTROL_2 (address 0x10) doesn't exist on the
> ST part.
>
> This is a work around for this by using the interrupt source register that
> should behave the same on both parts and has the needed information.
>
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Tested-by: Roland Stigge <stigge@antcom.de>
> ---
>
> This patch is very important to LPC32xx users. IMHO this should go in for 3.7-rc2.
>
> drivers/usb/gadget/lpc32xx_udc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
> index f696fb9..21a9861 100644
> --- a/drivers/usb/gadget/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/lpc32xx_udc.c
> @@ -2930,10 +2930,10 @@ static void vbus_work(struct work_struct *work)
>
> /* Get the VBUS status from the transceiver */
> value = i2c_smbus_read_byte_data(udc->isp1301_i2c_client,
> - ISP1301_I2C_OTG_CONTROL_2);
> + ISP1301_I2C_INTERRUPT_SOURCE);
>
> /* VBUS on or off? */
> - if (value & OTG_B_SESS_VLD)
> + if (value & INT_SESS_VLD)
> udc->vbus = 1;
> else
> udc->vbus = 0;
prev parent reply other threads:[~2012-10-15 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 12:47 [PATCH RESEND] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04 Alexandre Pereira da Silva
2012-10-15 12:47 ` [PATCH RESEND] usb: gadget: lpc32xx_udc: Disable setup request error Alexandre Pereira da Silva
2012-10-15 14:27 ` Roland Stigge
2012-10-15 13:01 ` [PATCH RESEND] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04 Felipe Balbi
2012-10-15 14:27 ` Roland Stigge
2012-10-15 14:24 ` Roland Stigge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507C1CB4.7070203@antcom.de \
--to=stigge@antcom.de \
--cc=aletes.xgr@gmail.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox