public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Markus F.X.J. Oberhumer" <markus@oberhumer.com>
To: cover.1349621096.git.markus@oberhumer.co
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	Johannes Stezenbach <js@sig21.net>,
	Richard Weinberger <richard.weinberger@gmail.com>
Subject: Re: [PATCH 0/3] Update LZO compression
Date: Tue, 16 Oct 2012 01:45:04 +0200	[thread overview]
Message-ID: <507CA000.5040905@oberhumer.com> (raw)
In-Reply-To: <507C61B2.9060503@linux.vnet.ibm.com>

On 2012-10-15 21:19, Seth Jennings wrote:
>> As requested by akpm I am sending my "lzo-update" branch at
>>
>>   git://github.com/markus-oberhumer/linux.git lzo-update
>>
>> to lkml as a patch series created by "git format-patch -M v3.5..lzo-update".
>>
>> You can also browse the branch at
>>
>>   https://github.com/markus-oberhumer/linux/compare/lzo-update
>>
>> and review the three patches at
>>
>>   https://github.com/markus-oberhumer/linux/commit/7c979cebc0f93dc692b734c12665a6824d219c20
>>   https://github.com/markus-oberhumer/linux/commit/10f6781c8591fe5fe4c8c733131915e5ae057826
>>   https://github.com/markus-oberhumer/linux/commit/5f702781f158cb59075cfa97e5c21f52275057f1
> 
> As this relates to my work on zcache, I just tested these patches on PPC64 and
> they cause the LZO crypto module to fail its self-test:
> 
> [    0.521137] alg: comp: Compression test 1 failed for lzo-generic: output len = 62
> 
> I built the exact same kernel for x86_64 and all is fine.  I suspect an endianness
> related bug, but I haven't looked at the code that closely yet.
> 
> Any ideas?  I'd be happy to test any potential fixes.

The crypto LZO test vectors had to be updated - this should land in linux-next
soon (or you can just pull from my branch).

BTW, this cannot have worked on x86_64 (or any other arch), so you probably
tested the wrong kernel.

Cheers,
Markus

> Seth

-- 
Markus Oberhumer, <markus@oberhumer.com>, http://www.oberhumer.com/

  reply	other threads:[~2012-10-15 23:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 19:19 [PATCH 0/3] Update LZO compression Seth Jennings
2012-10-15 23:45 ` Markus F.X.J. Oberhumer [this message]
2012-10-16 16:50   ` Seth Jennings
  -- strict thread matches above, loose matches on Subject: below --
2012-10-07 15:07 Markus F.X.J. Oberhumer
2012-10-09 19:26 ` Andrew Morton
2012-10-09 19:54   ` Markus F.X.J. Oberhumer
2012-10-09 22:43     ` Stephen Rothwell
2012-10-11 11:41     ` Arnd Bergmann
2012-10-11 16:28       ` Markus F.X.J. Oberhumer
2012-12-21  2:03         ` Dan Magenheimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507CA000.5040905@oberhumer.com \
    --to=markus@oberhumer.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=cover.1349621096.git.markus@oberhumer.co \
    --cc=js@sig21.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=richard.weinberger@gmail.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox