From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@nvidia.com>,
Anmar Oueja <anmar.oueja@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Patrice Chotard <patrice.chotard@st.com>,
Jean Nicolas Graux <jean-nicolas.graux@stericsson.com>,
Loic Pallardy <loic.pallardy@st.com>
Subject: Re: [PATCH] pinctrl: reserve pins when states are activated
Date: Thu, 18 Oct 2012 17:33:24 -0600 [thread overview]
Message-ID: <508091C4.9080008@wwwdotorg.org> (raw)
In-Reply-To: <1350554487-7914-1-git-send-email-linus.walleij@stericsson.com>
On 10/18/2012 04:01 AM, Linus Walleij wrote:
> This switches the way that pins are reserved for multiplexing:
The conceptual change makes perfect sense to me.
> diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
> void pinmux_free_setting(struct pinctrl_setting const *setting)
...
> + /*
> + * If a setting is active, disable it so that all pins are released
> + */
> + pinmux_disable_setting(setting);
"*If* a setting is active ..." implies there should be a C if statement
here to check if the setting is actually active before trying to disable it?
next prev parent reply other threads:[~2012-10-18 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 10:01 [PATCH] pinctrl: reserve pins when states are activated Linus Walleij
2012-10-18 23:33 ` Stephen Warren [this message]
2012-10-19 12:51 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2012-10-22 8:15 Linus Walleij
2012-10-22 20:11 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508091C4.9080008@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=anmar.oueja@linaro.org \
--cc=jean-nicolas.graux@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=patrice.chotard@st.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox