From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6283C371D00 for ; Wed, 1 Jul 2026 16:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782923929; cv=none; b=R1kInylvuz0Fu5BG8OaZQ6EWeBsP++6VS5NP7B7b8jh5CFD3gixXbEBvs0B9HnMNmSKIeQS2auQHUxepmLB2p0IDPNkHT4u8eAXDUxln4EkNRz3mydqKvcmxT9XuAW85IUSiuV5qneAF7giL3vP2sgqeIVNNMkXA1BgZnNpNnJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782923929; c=relaxed/simple; bh=Z73BRigvipTosPH+JY/h0wMUSCIc2qnWizSBcPALew0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XB9ghjp8iK4zeozdeL4vWu4/GJSrrBSxiyK33ZvbeDyZthJa9Yf5IQWwzH4AlTQ9gmx7tDTRWgp1ihbhzYP/o97hgiHw+bZlcYlio51VTH7hpnN4d4jNo0/H8E4cBnSa16PTCpsyO1J126ZRvgL8Ap28qwINtrlTyc0atTgwbHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codeweavers.com; spf=pass smtp.mailfrom=codeweavers.com; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b=sTUgl7XI; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=CQoTUjey; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codeweavers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeweavers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b="sTUgl7XI"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="CQoTUjey" Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id 91C5F140017D; Wed, 1 Jul 2026 12:38:47 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Wed, 01 Jul 2026 12:38:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeweavers.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1782923927; x=1783010327; bh=8Fto6dQBZRWglSlpA3a5Y2jT8SxRNeeL nC2vCWXtphs=; b=sTUgl7XI0DTrVQntIqBPg+jU+KGw0qWrHnGIwd0xVqUowdbj qsjJdjH2tEIROC7pBnoLYNTPcqBhv1i+0DrhFU4hrAJ/jyguJJPDuiuTDAAUYNmL FPzmpod8RKa63+/c146O72r9ILM/bXQAFysyYygcdWERpWTnkIof1+cBIZx9RabI aZbx2hUDXKHWZwQEzY1WmIEJUuybE3ujS70KuZvY+FTv5fACCDwmNVj/BJCwvMuZ 3odT971uLJFV9CcdAYtASMik6e21VXfRG7SHHFPS6lRq4XOkUv4WoyqRL1Kqw9hW Z5LZRegjmIUZ/HV1VjQ0pp+MQes8IVtBGZU4AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1782923927; x= 1783010327; bh=8Fto6dQBZRWglSlpA3a5Y2jT8SxRNeeLnC2vCWXtphs=; b=C QoTUjeyfVaEs2/RtptO21cCfKyio28ZGJ4kyuWJIohVbpNiv4CIAGrMtDXOXQHs5 uGWeN2CsRacMTU5KheE8I4hTwz55yEd1NVZGrmlx/CZa21eaXujBCBKWvDegIUsZ gORGaIf5zOJ1YoRdwB/ODse/iYSz8zBwfELvC5ZP6C+/sypWfG3fdFlBsW/NSU+C +MaB6+N+gpgzy+Gzc5+eQKvZhDAUQ3R46TIj/22t8dkVlHymBOi2ZWyDyParVr5k B72J2fpSMHf2l49T7Dx0bDbcXGjflqnfAwgH3b1LMXYbw+A5XoAYHE9WKGM5JL7+ 4DPCrPR+rZnt1cppeOZWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFUg94+qM/JMwYrkv0kabcrnn+Ps5mfjyvmdnh5fTfJXbFaXulKvwQlLO/yJPzf2b HSGUngpXHdcr09rXHpIre4CJpUD1/P+eZBsRpMounb2zihcZKvdjRHXwrmdLBx92ZluSFJ BbWmwfI0dXKvGI0STKMdGVav18UI/wDMjNQQioc+Ieo0gqHkVvsQQGFfLPMks1Na0mQvV7 A3QJjlPG9mXUaYEVDGwlXO3Va84IVBs8gZenrnI6UQ1AfUzgOJl5MzVAcjIOyw3tjrc1mQ eIpRzF3qTXbRDgsIkzXUQ5uk7GowS1C6Unn1lGfvi7mnZrH9S/sEk7HirPfeEVYYEU7vN3 eYJa+/jYItLB2GFP+l3lrnCGqDHx1/nvg5tDH9DwKN8lkzGsqM+DPDltGUBCTTlWWEgIJQ OjXx1yPEDhmB+Lo80A/jTnsfeXZC3/BqdDbqqyUxlGPYdkCVN0kHHWfWHmQFawPEex65ga zBMySVbjNz4uZ+tjqMOqDBCo9fzzE8VYxQ1IfzxR2QCxRnXuww1lvF6mPVHSvx44p/zdm4 h6yLsPup/lG6tcRy8+4QRYy+jjQieU9tLlpuSYxF1F3iO6I/B9+I2DFzvyQX+GcNSlfoyv WBFSdddG+MO0Hpq/4m9eDLdnwS9NwQYRSFYg9e03gHDtEBbGXj4pkCNhC38A X-ME-Proxy: Feedback-ID: i01ae4b70:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Jul 2026 12:38:47 -0400 (EDT) From: Elizabeth Figura To: =?UTF-8?B?SXbDoW4=?= Ezequiel Rodriguez Cc: wine-devel@winehq.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] ntsync: reject wait ioctls with zero owner Date: Wed, 01 Jul 2026 11:38:46 -0500 Message-ID: <5081647.GXAFRqVoOG@camazotz> In-Reply-To: <20260628024239.152852-5-ivanrwcm25@gmail.com> References: <20260628024239.152852-1-ivanrwcm25@gmail.com> <20260628024239.152852-5-ivanrwcm25@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Saturday, 27 June 2026 21:42:39 CDT Iv=C3=A1n Ezequiel Rodriguez wrote: > setup_wait() already validates pad and flags but not owner, while > Documentation/userspace-api/ntsync.rst requires EINVAL when owner is > zero. Reject early before queueing waiters. >=20 > Signed-off-by: Iv=C3=A1n Ezequiel Rodriguez > --- > drivers/misc/ntsync.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c > index 02c9d1192812..4a805919bb0c 100644 > --- a/drivers/misc/ntsync.c > +++ b/drivers/misc/ntsync.c > @@ -875,6 +875,9 @@ static int setup_wait(struct ntsync_device *dev, > if (args->pad || (args->flags & ~NTSYNC_WAIT_REALTIME)) > return -EINVAL; > =20 > + if (!args->owner) > + return -EINVAL; > + > if (size >=3D sizeof(fds)) > return -EINVAL; > =20 >=20 Reviewed-by: Elizabeth Figura