* [PATCH 1/3] lp8788-charger: use consumer device name on setting IIO channels
@ 2012-10-18 6:11 Kim, Milo
2012-10-19 15:37 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Kim, Milo @ 2012-10-18 6:11 UTC (permalink / raw)
To: cbou@mail.ru
Cc: Anton Vorontsov, Lars-Peter Clausen, Jonathan Cameron,
linux-kernel@vger.kernel.org
To get the ADC value for the battery voltage and temperature,
LP8788 ADC driver is used.
LP8788 charger driver is the consumer of LP8788 ADC driver.
Thus, specific ADC driver name is required on getting the channel
using iio_channel_get().
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
drivers/power/lp8788-charger.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/power/lp8788-charger.c b/drivers/power/lp8788-charger.c
index e852d12..614e6aa 100644
--- a/drivers/power/lp8788-charger.c
+++ b/drivers/power/lp8788-charger.c
@@ -592,7 +592,8 @@ static void lp8788_irq_unregister(struct platform_device *pdev,
}
}
-static void lp8788_setup_adc_channel(struct lp8788_charger *pchg)
+static void lp8788_setup_adc_channel(const char *consumer_name,
+ struct lp8788_charger *pchg)
{
struct lp8788_charger_platform_data *pdata = pchg->pdata;
struct device *dev = pchg->lp->dev;
@@ -616,7 +617,7 @@ static void lp8788_setup_adc_channel(struct lp8788_charger *pchg)
case LPADC_VBATT_5P5:
case LPADC_VBATT_6P0:
case LPADC_VBATT_5P0:
- chan = iio_channel_get(NULL, chan_name[id]);
+ chan = iio_channel_get(consumer_name, chan_name[id]);
pchg->chan[LP8788_VBATT] = IS_ERR(chan) ? NULL : chan;
break;
default:
@@ -631,7 +632,7 @@ static void lp8788_setup_adc_channel(struct lp8788_charger *pchg)
case LPADC_ADC2:
case LPADC_ADC3:
case LPADC_ADC4:
- chan = iio_channel_get(NULL, chan_name[id]);
+ chan = iio_channel_get(consumer_name, chan_name[id]);
pchg->chan[LP8788_BATT_TEMP] = IS_ERR(chan) ? NULL : chan;
break;
default:
@@ -747,7 +748,7 @@ static __devinit int lp8788_charger_probe(struct platform_device *pdev)
if (ret)
return ret;
- lp8788_setup_adc_channel(pchg);
+ lp8788_setup_adc_channel(pdev->name, pchg);
ret = lp8788_psy_register(pdev, pchg);
if (ret)
--
1.7.9.5
Best Regards,
Milo
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] lp8788-charger: use consumer device name on setting IIO channels
2012-10-18 6:11 [PATCH 1/3] lp8788-charger: use consumer device name on setting IIO channels Kim, Milo
@ 2012-10-19 15:37 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2012-10-19 15:37 UTC (permalink / raw)
To: Kim, Milo
Cc: cbou@mail.ru, Anton Vorontsov, Lars-Peter Clausen,
linux-kernel@vger.kernel.org
On 10/18/2012 07:11 AM, Kim, Milo wrote:
> To get the ADC value for the battery voltage and temperature,
> LP8788 ADC driver is used.
> LP8788 charger driver is the consumer of LP8788 ADC driver.
> Thus, specific ADC driver name is required on getting the channel
> using iio_channel_get().
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/power/lp8788-charger.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/power/lp8788-charger.c b/drivers/power/lp8788-charger.c
> index e852d12..614e6aa 100644
> --- a/drivers/power/lp8788-charger.c
> +++ b/drivers/power/lp8788-charger.c
> @@ -592,7 +592,8 @@ static void lp8788_irq_unregister(struct platform_device *pdev,
> }
> }
>
> -static void lp8788_setup_adc_channel(struct lp8788_charger *pchg)
> +static void lp8788_setup_adc_channel(const char *consumer_name,
> + struct lp8788_charger *pchg)
> {
> struct lp8788_charger_platform_data *pdata = pchg->pdata;
> struct device *dev = pchg->lp->dev;
> @@ -616,7 +617,7 @@ static void lp8788_setup_adc_channel(struct lp8788_charger *pchg)
> case LPADC_VBATT_5P5:
> case LPADC_VBATT_6P0:
> case LPADC_VBATT_5P0:
> - chan = iio_channel_get(NULL, chan_name[id]);
> + chan = iio_channel_get(consumer_name, chan_name[id]);
> pchg->chan[LP8788_VBATT] = IS_ERR(chan) ? NULL : chan;
> break;
> default:
> @@ -631,7 +632,7 @@ static void lp8788_setup_adc_channel(struct lp8788_charger *pchg)
> case LPADC_ADC2:
> case LPADC_ADC3:
> case LPADC_ADC4:
> - chan = iio_channel_get(NULL, chan_name[id]);
> + chan = iio_channel_get(consumer_name, chan_name[id]);
> pchg->chan[LP8788_BATT_TEMP] = IS_ERR(chan) ? NULL : chan;
> break;
> default:
> @@ -747,7 +748,7 @@ static __devinit int lp8788_charger_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - lp8788_setup_adc_channel(pchg);
> + lp8788_setup_adc_channel(pdev->name, pchg);
>
> ret = lp8788_psy_register(pdev, pchg);
> if (ret)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-19 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-18 6:11 [PATCH 1/3] lp8788-charger: use consumer device name on setting IIO channels Kim, Milo
2012-10-19 15:37 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).