From: Bart Van Assche <bvanassche@acm.org>
To: Jay Fenlason <fenlason@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] prevent CVE-2012-2372 rds-ping causes kernel panic
Date: Mon, 22 Oct 2012 20:25:48 +0200 [thread overview]
Message-ID: <50858FAC.10509@acm.org> (raw)
In-Reply-To: <20121022181253.GA13736@redhat.com>
On 10/22/12 20:12, Jay Fenlason wrote:
> If you use rds-ping of the local IP address of some Infiniband HCAs
> (QLogic, possibly others) the machine will panic with a BUG_ON due to
> an overly restrictive check. Loosen the restriction a bit
>
> This should have gotten sent a while ago (it was first noticed in
> https://bugzilla.redhat.com/show_bug.cgi?id=803936
> and patched in kernel-2.6.32-275.el6) but I got confused about its
> embargo status and lost it.
>
> Signed-off-by: Jay Fenlason <fenlason@redhat.com>
>
> diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
> index e590949..7920c85 100644
> --- a/net/rds/ib_send.c
> +++ b/net/rds/ib_send.c
> @@ -544,7 +544,7 @@ int rds_ib_xmit(struct rds_connection *conn, struct rds_message *rm,
> int flow_controlled = 0;
> int nr_sig = 0;
>
> - BUG_ON(off % RDS_FRAG_SIZE);
> + BUG_ON(!conn->c_loopback && off % RDS_FRAG_SIZE);
> BUG_ON(hdr_off != 0 && hdr_off != sizeof(struct rds_header));
>
> /* Do not send cong updates to IB loopback */
Hello Jay,
The recommended approach for checking preconditions is to use
WARN_ON_ONCE(), not BUG_ON(). Linus explained this last month in a
message posted on the LKML (http://lkml.org/lkml/2012/9/27/461).
Bart.
prev parent reply other threads:[~2012-10-22 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 18:12 [PATCH] prevent CVE-2012-2372 rds-ping causes kernel panic Jay Fenlason
2012-10-22 18:19 ` Greg KH
2012-10-22 18:25 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50858FAC.10509@acm.org \
--to=bvanassche@acm.org \
--cc=fenlason@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox