From: Jens Axboe <axboe@kernel.dk>
To: Anna Leuschner <anna.m.leuschner@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: fix: don't increase bio_slab_max if krealloc() fails
Date: Mon, 22 Oct 2012 20:40:45 +0200 [thread overview]
Message-ID: <5085932D.4000108@kernel.dk> (raw)
In-Reply-To: <1350851609-10541-1-git-send-email-anna.m.leuschner@gmail.com>
On 2012-10-21 22:33, Anna Leuschner wrote:
> bio.c: fix: don't increase bio_slab_max if krealloc() of bio_slabs fails
You failed the "how to write a commit message" part of the patch :-)
The commit message should talk about WHY a change is necessary, not
HOW it is done. The latter should be obvious from looking at the code
change.
So, in other words, please describe why the change is useful or needed.
Then resend.
--
Jens Axboe
prev parent reply other threads:[~2012-10-22 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-21 20:33 [PATCH] vfs: fix: don't increase bio_slab_max if krealloc() fails Anna Leuschner
2012-10-22 18:40 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5085932D.4000108@kernel.dk \
--to=axboe@kernel.dk \
--cc=anna.m.leuschner@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).