From: Jens Axboe <axboe@kernel.dk>
To: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tejun Heo <tj@kernel.org>, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] blkcg: stop iteration early if root_rl is the only request list
Date: Mon, 22 Oct 2012 20:43:32 +0200 [thread overview]
Message-ID: <508593D4.20908@kernel.dk> (raw)
In-Reply-To: <50849E39.2040609@ce.jp.nec.com>
On 2012-10-22 03:15, Jun'ichi Nomura wrote:
> __blk_queue_next_rl() finds next request list based on blkg_list
> while skipping root_blkg in the list.
> OTOH, root_rl is special as it may exist even without root_blkg.
>
> Though the later part of the function handles such a case correctly,
> exiting early is good for readability of the code.
Applied to for-linus, thanks.
--
Jens Axboe
prev parent reply other threads:[~2012-10-22 18:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 5:11 [PATCH] Fix use-after-free of q->root_blkg and q->root_rl.blkg Jun'ichi Nomura
2012-10-10 15:59 ` Vivek Goyal
2012-10-11 1:31 ` Jun'ichi Nomura
2012-10-11 18:55 ` Vivek Goyal
2012-10-16 23:20 ` Tejun Heo
2012-10-17 0:02 ` Jun'ichi Nomura
2012-10-17 8:45 ` [PATCH] blkcg: " Jun'ichi Nomura
2012-10-18 21:21 ` Tejun Heo
2012-10-22 18:43 ` Jens Axboe
2012-10-17 13:47 ` [PATCH] " Vivek Goyal
2012-10-18 2:56 ` Jun'ichi Nomura
2012-10-18 13:31 ` Vivek Goyal
2012-10-18 21:20 ` Tejun Heo
2012-10-19 14:53 ` Vivek Goyal
2012-10-22 0:55 ` Jun'ichi Nomura
2012-10-22 1:15 ` [PATCH] blkcg: stop iteration early if root_rl is the only request list Jun'ichi Nomura
2012-10-22 15:31 ` Vivek Goyal
2012-10-22 18:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508593D4.20908@kernel.dk \
--to=axboe@kernel.dk \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).