From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758548Ab2JXMP3 (ORCPT ); Wed, 24 Oct 2012 08:15:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28188 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758373Ab2JXMP1 (ORCPT ); Wed, 24 Oct 2012 08:15:27 -0400 Message-ID: <5087DBD9.9010707@redhat.com> Date: Wed, 24 Oct 2012 08:15:21 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110419 Red Hat/3.1.10-1.el6_0 Thunderbird/3.1.10 MIME-Version: 1.0 To: Ingo Molnar CC: linux-kernel@vger.kernel.org, Avi Kivity , Gleb Natapov , Alex Williamson , Marcelo Tostatti , Ingo Molnar , kvm@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] x86, add hypervisor name to dump_stack() References: <1349879268-3573-1-git-send-email-prarit@redhat.com> <20121024094944.GB4814@gmail.com> In-Reply-To: <20121024094944.GB4814@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2012 05:49 AM, Ingo Molnar wrote: > > * Prarit Bhargava wrote: > >> Debugging crash, panics, stack trace WARN_ONs, etc., from both virtual and >> bare-metal boots can get difficult very quickly. While there are ways to >> decipher the output and determine if the output is from a virtual guest, >> the in-kernel hypervisors now have a single registration point and set >> x86_hyper. We can use this to output a single extra line on virtual >> machines that indicates the hypervisor type. >> >> Signed-off-by: Prarit Bhargava >> Cc: Avi Kivity >> Cc: Gleb Natapov >> Cc: Alex Williamson >> Cc: Marcelo Tostatti >> Cc: Ingo Molnar >> Cc: kvm@vger.kernel.org >> Cc: x86@kernel.org >> --- >> arch/x86/kernel/dumpstack.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c >> index ae42418b..75a635e 100644 >> --- a/arch/x86/kernel/dumpstack.c >> +++ b/arch/x86/kernel/dumpstack.c >> @@ -17,6 +17,7 @@ >> #include >> >> #include >> +#include >> >> >> int panic_on_unrecovered_nmi; >> @@ -193,6 +194,8 @@ void dump_stack(void) >> init_utsname()->release, >> (int)strcspn(init_utsname()->version, " "), >> init_utsname()->version); >> + if (x86_hyper && x86_hyper->name) >> + printk("Hypervisor: %s\n", x86_hyper->name); >> show_trace(NULL, NULL, &stack, bp); > > Looks useful, but please don't waste a full new line on it but > embedd it in the already existing status line that prints > details like release and version. Ingo, I thought about doing that but since x86_hyper can be NULL (... maybe it should initialized to "Bare-metal" or "No Hypervisor"?) I didn't want to break up the printk line. I'll look into doing it a different way... P. > > Thanks, > > Ingo