From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756138Ab2J1Vtb (ORCPT ); Sun, 28 Oct 2012 17:49:31 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:49131 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756075Ab2J1Vt3 (ORCPT ); Sun, 28 Oct 2012 17:49:29 -0400 Message-ID: <508DA864.8020503@linaro.org> Date: Sun, 28 Oct 2012 22:49:24 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jingoo Han CC: "'Rafael J. Wysocki'" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuidle: add missing header include References: <001401cdb332$93ffe450$bbffacf0$%han@samsung.com> In-Reply-To: <001401cdb332$93ffe450$bbffacf0$%han@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2012 06:30 AM, Jingoo Han wrote: > This patch adds missing device.h header to fix build warnings as below: > > drivers/cpuidle/cpuidle.h:26:41: warning: 'struct device' declared inside parameter list [enabled by default] > drivers/cpuidle/cpuidle.h:26:41: warning: its scope is only this definition or declaration, which is probably not what you want > [enabled by default] > drivers/cpuidle/cpuidle.h:27:45: warning: 'struct device' declared inside parameter list [enabled by default] > In file included from drivers/cpuidle/driver.c:15:0: > drivers/cpuidle/cpuidle.h:26:41: warning: 'struct device' declared inside parameter list [enabled by default] > drivers/cpuidle/cpuidle.h:26:41: warning: its scope is only this definition or declaration, which is probably not what you want > [enabled by default] > drivers/cpuidle/cpuidle.h:27:45: warning: 'struct device' declared inside parameter list [enabled by default] > > This build warning is introduced by commit efeca1b > "cpuidle / sysfs: change function parameter". > > Signed-off-by: Jingoo Han > Cc: Daniel Lezcano > --- Jingoo, could you copy-pastebin your config file. I don't have this warning and I would like to understand why. Thanks -- Daniel > drivers/cpuidle/cpuidle.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle.h b/drivers/cpuidle/cpuidle.h > index a5bbd1c..2120d9e 100644 > --- a/drivers/cpuidle/cpuidle.h > +++ b/drivers/cpuidle/cpuidle.h > @@ -5,6 +5,8 @@ > #ifndef __DRIVER_CPUIDLE_H > #define __DRIVER_CPUIDLE_H > > +#include > + > /* For internal use only */ > extern struct cpuidle_governor *cpuidle_curr_governor; > extern struct list_head cpuidle_governors; -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog