From: gshark <gshark.jeong@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Richard Purdie <rpurdie@rpsys.net>,
Daniel Jeong <daniel.jeong@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backlight: lm3639_bl: Fix up world writable sysfs file
Date: Mon, 29 Oct 2012 20:02:35 +0900 [thread overview]
Message-ID: <508E624B.8020207@gmail.com> (raw)
In-Reply-To: <1351499898.14725.5.camel@phoenix>
2012년 10월 29일 17:38, Axel Lin 쓴 글:
> We don't need the sysfs file to be world writable or group writable.
> This file is write-only, change it to S_IWUSR (0200).
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/video/backlight/lm3639_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
> index 585949b..6f7a20e 100644
> --- a/drivers/video/backlight/lm3639_bl.c
> +++ b/drivers/video/backlight/lm3639_bl.c
> @@ -214,7 +214,7 @@ out_input:
>
> }
>
> -static DEVICE_ATTR(bled_mode, 0666, NULL, lm3639_bled_mode_store);
> +static DEVICE_ATTR(bled_mode, S_IWUSR, NULL, lm3639_bled_mode_store);
>
> /* torch */
> static void lm3639_torch_brightness_set(struct led_classdev *cdev,
It's also nice to us. Thank you Alex.
Acked-by: G.Shark Jeong<gshark.jeong@gmail.com>
prev parent reply other threads:[~2012-10-29 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 8:38 [PATCH] backlight: lm3639_bl: Fix up world writable sysfs file Axel Lin
2012-10-29 11:02 ` gshark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E624B.8020207@gmail.com \
--to=gshark.jeong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@ingics.com \
--cc=daniel.jeong@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox