From: "H. Peter Anvin" <hpa@zytor.com>
To: Robert Richter <rric@kernel.org>
Cc: "Zhang, Jun" <jun.zhang@intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>,
"oprofile-list@lists.sf.net" <oprofile-list@lists.sf.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Sometimes, there is OOPS happened when we use oprofile.
Date: Wed, 31 Oct 2012 14:33:17 -0700 [thread overview]
Message-ID: <5091991D.4020202@zytor.com> (raw)
In-Reply-To: <20121031210522.GB4386@ivy.homofaber>
On 10/31/2012 02:05 PM, Robert Richter wrote:
> Jun,
>
> On 29.10.12 02:33:54, Zhang, Jun wrote:
>> Sometimes, there is OOPS happened when we use oprofile. next
>> is the call stack. From call stack, we find in
>> call_on_stack if there is a nmi interrupt between "xchgl
>> %%ebx,%%esp" and "call *%%edi", system will OOPS.
>
> this should be related and fixed with:
>
> https://lkml.org/lkml/2012/9/12/269
>
> Ingo, HPA,
>
> please apply the fix of kernel_stack_pointer().
>
I'm vaguely concerned about the following:
+ * To always return a non-null
+ * stack pointer we fall back to regs as stack if no previous stack
+ * exists.
The logic being that if there is no stack pointer and the stack is too
empty, to simply assume regs point to the top of the stack? Is this
possible to ever be actually seen?
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-10-31 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 2:33 [PATCH] Sometimes, there is OOPS happened when we use oprofile Zhang, Jun
2012-10-31 21:05 ` Robert Richter
2012-10-31 21:27 ` H. Peter Anvin
2012-10-31 21:33 ` H. Peter Anvin [this message]
2012-10-31 22:45 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5091991D.4020202@zytor.com \
--to=hpa@zytor.com \
--cc=jun.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oprofile-list@lists.sf.net \
--cc=rric@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox