From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: regulator: tps51632: Seems current code doesn't properly support dvfs_step_20mV case
Date: Thu, 1 Nov 2012 13:16:55 +0530 [thread overview]
Message-ID: <509228EF.7000307@nvidia.com> (raw)
In-Reply-To: <1351752521.4588.2.camel@phoenix>
On Thursday 01 November 2012 12:18 PM, Axel Lin wrote:
> Hi Laxman,
>
> While reading the tps51632 driver, I found there is a dvfs_step_20mV setting
> in platform data. But seems current code doesn't properly handle the case when
> dvfs_step_20mV is true.
>
> I guess if pdata->dvfs_step_20mV is true, we need:
>
> tps->desc.uV_step = TPS51632_VOLATGE_STEP_20mV;
> Fix TPS51632_VOLT_VSEL macro to support dvfs_step_20mV case.
> Also I'm wondering if either TPS51632_MAX_VSEL/TPS51632_MAX_VOLATGE or
> desc.n_voltages needs change for dvfs_step_20mV case.
>
> Oh, I don't have the datasheet, so my understanding might be wrong.
The steps for voltage and voltage base registers are the 10mV always.
The DVFS steps are used only when the steps (offsets) are provided
through PWM.
So in DVFS case the vout = voltage_base + pwm_offset* dvfs_steps.
And voltage_base = min_volt + sel * 10mV.
prev parent reply other threads:[~2012-11-01 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 6:48 regulator: tps51632: Seems current code doesn't properly support dvfs_step_20mV case Axel Lin
2012-11-01 7:46 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509228EF.7000307@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox