From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762716Ab2KBLbm (ORCPT ); Fri, 2 Nov 2012 07:31:42 -0400 Received: from georges.telenet-ops.be ([195.130.137.68]:40598 "EHLO georges.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112Ab2KBLbk (ORCPT ); Fri, 2 Nov 2012 07:31:40 -0400 Message-ID: <5093AF19.5040707@acm.org> Date: Fri, 02 Nov 2012 12:31:37 +0100 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 MIME-Version: 1.0 To: Jeff Moyer CC: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org Subject: Re: [patch 01/10] scsi: make __scsi_alloc_queue numa-aware References: <1351628084-29358-1-git-send-email-jmoyer@redhat.com> <1351628084-29358-4-git-send-email-jmoyer@redhat.com> In-Reply-To: <1351628084-29358-4-git-send-email-jmoyer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/12 21:14, Jeff Moyer wrote: > Pass the numa node id set in the Scsi_Host on to blk_init_queue_node > in order to keep all allocations local to the numa node the device is > closest to. > > Signed-off-by: Jeff Moyer > --- > drivers/scsi/scsi_lib.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > index da36a3a..8662a09 100644 > --- a/drivers/scsi/scsi_lib.c > +++ b/drivers/scsi/scsi_lib.c > @@ -1664,7 +1664,7 @@ struct request_queue *__scsi_alloc_queue(struct Scsi_Host *shost, > struct request_queue *q; > struct device *dev = shost->dma_dev; > > - q = blk_init_queue(request_fn, NULL); > + q = blk_init_queue_node(request_fn, NULL, shost->numa_node); > if (!q) > return NULL; Hello Jeff, I haven't seen the patch that introduces numa_node in struct Scsi_Host nor the cover letter of this patch series ? Have these been posted on the linux-scsi mailing list ? Bart.