From: Martyn Welch <martyn.welch@ge.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: manohar.vanga@gmail.com, gregkh@linuxfoundation.org,
yongjun_wei@trendmicro.com.cn, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vme: vme_vmivme7805.c: use module_pci_driver to simplify the code
Date: Fri, 02 Nov 2012 15:23:39 +0000 [thread overview]
Message-ID: <5093E57B.2020801@ge.com> (raw)
In-Reply-To: <CAPgLHd-jNUdrUE5cwm=+iEbJQb+N_Bdduwa9kMh_rJMmU=tYuw@mail.gmail.com>
On 18/10/2012 16:15, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use the module_pci_driver() macro to make the code simpler
> by eliminating module_init and module_exit calls.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/vme/boards/vme_vmivme7805.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/drivers/vme/boards/vme_vmivme7805.c b/drivers/vme/boards/vme_vmivme7805.c
> index 8e05bb4..dd22b50 100644
> --- a/drivers/vme/boards/vme_vmivme7805.c
> +++ b/drivers/vme/boards/vme_vmivme7805.c
> @@ -19,10 +19,8 @@
>
> #include "vme_vmivme7805.h"
>
> -static int __init vmic_init(void);
> static int vmic_probe(struct pci_dev *, const struct pci_device_id *);
> static void vmic_remove(struct pci_dev *);
> -static void __exit vmic_exit(void);
>
> /** Base address to access FPGA register */
> static void *vmic_base;
> @@ -41,11 +39,6 @@ static struct pci_driver vmic_driver = {
> .remove = vmic_remove,
> };
>
> -static int __init vmic_init(void)
> -{
> - return pci_register_driver(&vmic_driver);
> -}
> -
> static int vmic_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> {
> int retval;
> @@ -109,15 +102,9 @@ static void vmic_remove(struct pci_dev *pdev)
>
> }
>
> -static void __exit vmic_exit(void)
> -{
> - pci_unregister_driver(&vmic_driver);
> -}
> +module_pci_driver(vmic_driver);
>
> MODULE_DESCRIPTION("VMIVME-7805 board support driver");
> MODULE_AUTHOR("Arthur Benilov <arthur.benilov@iba-group.com>");
> MODULE_LICENSE("GPL");
>
> -module_init(vmic_init);
> -module_exit(vmic_exit);
> -
>
>
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.welch@ge.com | VAT:GB 927559189
prev parent reply other threads:[~2012-11-02 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 15:15 [PATCH] vme: vme_vmivme7805.c: use module_pci_driver to simplify the code Wei Yongjun
2012-11-02 15:23 ` Martyn Welch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093E57B.2020801@ge.com \
--to=martyn.welch@ge.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox