From: Shan Wei <shanwei88@gmail.com>
To: jesse@nicira.com, dev@openvswitch.org,
NetDev <netdev@vger.kernel.org>,
Kernel-Maillist <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
cl@linux-foundation.org, Shan Wei <shanwei88@gmail.com>
Subject: [PATCH 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper
Date: Sat, 03 Nov 2012 00:01:29 +0800 [thread overview]
Message-ID: <5093EE59.8010609@gmail.com> (raw)
From: Shan Wei <davidshan@tencent.com>
no change vs v1.
Lots of drivers use this kind to read/write per-cpu variable.
stats = this_cpu_ptr(dp->stats_percpu);
u64_stats_update_begin(&stats->sync);
stats->tx_packets++;
u64_stats_update_begin(&stats->sync);
Signed-off-by: Shan Wei <davidshan@tencent.com>
---
net/openvswitch/datapath.c | 4 ++--
net/openvswitch/vport.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index 4c4b62c..77d16a5 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -208,7 +208,7 @@ void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb)
int error;
int key_len;
- stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id());
+ stats = this_cpu_ptr(dp->stats_percpu);
/* Extract flow from 'skb' into 'key'. */
error = ovs_flow_extract(skb, p->port_no, &key, &key_len);
@@ -282,7 +282,7 @@ int ovs_dp_upcall(struct datapath *dp, struct sk_buff *skb,
return 0;
err:
- stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id());
+ stats = this_cpu_ptr(dp->stats_percpu);
u64_stats_update_begin(&stats->sync);
stats->n_lost++;
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 03779e8..70af0be 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -333,8 +333,7 @@ void ovs_vport_receive(struct vport *vport, struct sk_buff *skb)
{
struct vport_percpu_stats *stats;
- stats = per_cpu_ptr(vport->percpu_stats, smp_processor_id());
-
+ stats = this_cpu_ptr(vport->percpu_stats);
u64_stats_update_begin(&stats->sync);
stats->rx_packets++;
stats->rx_bytes += skb->len;
@@ -359,7 +358,7 @@ int ovs_vport_send(struct vport *vport, struct sk_buff *skb)
if (likely(sent)) {
struct vport_percpu_stats *stats;
- stats = per_cpu_ptr(vport->percpu_stats, smp_processor_id());
+ stats = this_cpu_ptr(vport->percpu_stats);
u64_stats_update_begin(&stats->sync);
stats->tx_packets++;
--
1.7.1
next reply other threads:[~2012-11-02 16:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 16:01 Shan Wei [this message]
2012-11-02 17:46 ` [PATCH 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper Christoph Lameter
2012-11-08 14:22 ` Shan Wei
2012-11-08 17:18 ` Christoph Lameter
2012-11-09 1:39 ` Shan Wei
-- strict thread matches above, loose matches on Subject: below --
2012-10-31 11:22 Shan Wei
2012-10-31 17:39 ` Christoph Lameter
2012-11-01 10:07 ` Shan Wei
2012-11-01 14:33 ` Christoph Lameter
2012-11-02 1:38 ` Jesse Gross
2012-11-02 14:01 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093EE59.8010609@gmail.com \
--to=shanwei88@gmail.com \
--cc=cl@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=jesse@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox