* [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper
@ 2012-11-02 16:02 Shan Wei
2012-11-02 17:48 ` Christoph Lameter
2012-11-02 17:55 ` [B.A.T.M.A.N.] " Sven Eckelmann
0 siblings, 2 replies; 6+ messages in thread
From: Shan Wei @ 2012-11-02 16:02 UTC (permalink / raw)
To: lindner_marek, siwu, ordex, b.a.t.m.a.n, David Miller, NetDev,
Kernel-Maillist, Shan Wei, Christoph Lameter
From: Shan Wei <davidshan@tencent.com>
As Christoph Lameter said:
> In addition, following usage of per_cpu_ptr can be replaced by this_cpu_read.
>
> cpu=get_cpu()
> ....
> *per_cpu_ptr(p,cpu)
> ....
> ....
> put_cpu()
Right.
Signed-off-by: Shan Wei <davidshan@tencent.com>
---
net/batman-adv/main.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index 897ba6a..3aef5b2 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp,
static inline void batadv_add_counter(struct batadv_priv *bat_priv, size_t idx,
size_t count)
{
- int cpu = get_cpu();
- per_cpu_ptr(bat_priv->bat_counters, cpu)[idx] += count;
- put_cpu();
+ this_cpu_add(bat_priv->bat_counters[idx], count);
}
#define batadv_inc_counter(b, i) batadv_add_counter(b, i, 1)
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper
2012-11-02 16:02 [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper Shan Wei
@ 2012-11-02 17:48 ` Christoph Lameter
2012-11-02 17:55 ` [B.A.T.M.A.N.] " Sven Eckelmann
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Lameter @ 2012-11-02 17:48 UTC (permalink / raw)
To: Shan Wei
Cc: lindner_marek, siwu, ordex, b.a.t.m.a.n, David Miller, NetDev,
Kernel-Maillist
On Sat, 3 Nov 2012, Shan Wei wrote:
> diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
> index 897ba6a..3aef5b2 100644
> --- a/net/batman-adv/main.h
> +++ b/net/batman-adv/main.h
> @@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp,
> static inline void batadv_add_counter(struct batadv_priv *bat_priv, size_t idx,
> size_t count)
> {
> - int cpu = get_cpu();
> - per_cpu_ptr(bat_priv->bat_counters, cpu)[idx] += count;
> - put_cpu();
> + this_cpu_add(bat_priv->bat_counters[idx], count);
> }
Reviewed-by: Christoph Lameter <cl@linux.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper
2012-11-02 16:02 [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper Shan Wei
2012-11-02 17:48 ` Christoph Lameter
@ 2012-11-02 17:55 ` Sven Eckelmann
2012-11-03 4:58 ` Shan Wei
1 sibling, 1 reply; 6+ messages in thread
From: Sven Eckelmann @ 2012-11-02 17:55 UTC (permalink / raw)
To: b.a.t.m.a.n
Cc: Shan Wei, lindner_marek, siwu, ordex, David Miller, NetDev,
Kernel-Maillist, Christoph Lameter
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
On Saturday 03 November 2012 00:02:06 Shan Wei wrote:
> From: Shan Wei <davidshan@tencent.com>
>
> As Christoph Lameter said:
> > In addition, following usage of per_cpu_ptr can be replaced by
> > this_cpu_read.
> >
> > cpu=get_cpu()
> > ....
> > *per_cpu_ptr(p,cpu)
> > ....
> > ....
> > put_cpu()
>
> Right.
>
> Signed-off-by: Shan Wei <davidshan@tencent.com>
> ---
Is this really supposed to be the commit message?
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper
2012-11-02 17:55 ` [B.A.T.M.A.N.] " Sven Eckelmann
@ 2012-11-03 4:58 ` Shan Wei
2012-11-03 22:39 ` Sven Eckelmann
2012-11-05 15:19 ` Christoph Lameter
0 siblings, 2 replies; 6+ messages in thread
From: Shan Wei @ 2012-11-03 4:58 UTC (permalink / raw)
To: Sven Eckelmann
Cc: b.a.t.m.a.n, lindner_marek, siwu, ordex, David Miller, NetDev,
Kernel-Maillist, Christoph Lameter
Sven Eckelmann said, at 2012/11/3 1:55:
> On Saturday 03 November 2012 00:02:06 Shan Wei wrote:
>> From: Shan Wei <davidshan@tencent.com>
>>
>> As Christoph Lameter said:
>>> In addition, following usage of per_cpu_ptr can be replaced by
>>> this_cpu_read.
>>>
>>> cpu=get_cpu()
>>> ....
>>> *per_cpu_ptr(p,cpu)
>>> ....
>>> ....
>>> put_cpu()
>>
>> Right.
>>
>> Signed-off-by: Shan Wei <davidshan@tencent.com>
>> ---
>
> Is this really supposed to be the commit message?
Maybe it's ok when Linus said this. :-)
Christoph is the maintainer of per-cpu.
So........
PER-CPU MEMORY ALLOCATOR
M: Tejun Heo <tj@kernel.org>
M: Christoph Lameter <cl@linux-foundation.org>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git
S: Maintained
F: include/linux/percpu*.h
F: mm/percpu*.c
F: arch/*/include/asm/percpu.h
>
> Kind regards,
> Sven
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper
2012-11-03 4:58 ` Shan Wei
@ 2012-11-03 22:39 ` Sven Eckelmann
2012-11-05 15:19 ` Christoph Lameter
1 sibling, 0 replies; 6+ messages in thread
From: Sven Eckelmann @ 2012-11-03 22:39 UTC (permalink / raw)
To: Shan Wei
Cc: b.a.t.m.a.n, lindner_marek, siwu, ordex, David Miller, NetDev,
Kernel-Maillist, Christoph Lameter
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
On Saturday 03 November 2012 12:58:45 Shan Wei wrote:
> Sven Eckelmann said, at 2012/11/3 1:55:
> > On Saturday 03 November 2012 00:02:06 Shan Wei wrote:
> >> From: Shan Wei <davidshan@tencent.com>
> >>
> >> As Christoph Lameter said:
> >>> In addition, following usage of per_cpu_ptr can be replaced by
> >>> this_cpu_read.
> >>>
> >>> cpu=get_cpu()
> >>> ....
> >>> *per_cpu_ptr(p,cpu)
> >>> ....
> >>> ....
> >>> put_cpu()
> >>
> >> Right.
> >>
> >> Signed-off-by: Shan Wei <davidshan@tencent.com>
> >> ---
> >
> > Is this really supposed to be the commit message?
>
> Maybe it's ok when Linus said this. :-)
>
> Christoph is the maintainer of per-cpu.
> So........
Hm? This wasn't my question, but ok...
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper
2012-11-03 4:58 ` Shan Wei
2012-11-03 22:39 ` Sven Eckelmann
@ 2012-11-05 15:19 ` Christoph Lameter
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Lameter @ 2012-11-05 15:19 UTC (permalink / raw)
To: Shan Wei
Cc: Sven Eckelmann, b.a.t.m.a.n, lindner_marek, siwu, ordex,
David Miller, NetDev, Kernel-Maillist
On Sat, 3 Nov 2012, Shan Wei wrote:
> > Is this really supposed to be the commit message?
>
> Maybe it's ok when Linus said this. :-)
>
> Christoph is the maintainer of per-cpu.
Well please make the changelog nice and understandable.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-05 15:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-02 16:02 [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper Shan Wei
2012-11-02 17:48 ` Christoph Lameter
2012-11-02 17:55 ` [B.A.T.M.A.N.] " Sven Eckelmann
2012-11-03 4:58 ` Shan Wei
2012-11-03 22:39 ` Sven Eckelmann
2012-11-05 15:19 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox