Re: [PATCH v6 23/29] memcg: destroy memcg caches

Andrew Morton
2012-11-06T00:40:18Z

On Thu, 1 Nov 2012 16:07:39 +0400
Glauber Costa <glommer@parallels.com> wrote:

> This patch implements destruction of memcg caches. Right now,
> only caches where our reference counter is the last remaining are
> deleted. If there are any other reference counters around, we just
> leave the caches lying around until they go away.
>
> When that happen, a destruction function is called from the cache
> code. Caches are only destroyed in process context, so we queue them
> up for later processing in the general case.
>
> ...
>
> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -181,6 +181,7 @@ unsigned int kmem_cache_size(struct kmem_cache *);
> #define ARCH_SLAB_MINALIGN __alignof__(unsigned long long)
> #endif
>
> +#include <linux/workqueue.h>

Was there any reason for putting this include 185 lines into the file?

If not, then let's not do it. It reduces readability and increases the
risk that someone will later include the saame file (or somthing it includes)
a second time, to satisfy some dependency at line 100.