From: Justin Swartz <justin.swartz@risingedge.co.za>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: add device tree for Mecer Xtreme Mini S6
Date: Fri, 26 Jul 2019 11:14:44 +0200 [thread overview]
Message-ID: <509782f4ece936f5ac7d0abffbd555fc@risingedge.co.za> (raw)
In-Reply-To: <1618985.EOrKlNyPW4@phil>
Hi Heiko,
On 2019-07-26 00:19, Heiko Stuebner wrote:
> please add an entry to
> Documentation/devicetree/bindings/arm/rockchip.yaml
> for your board and if necessary also a vendor-prefix to
> Documentation/devicetree/bindings/vendor-prefixes.(yaml?)
OK
> please sort the &node-references alphabetically.
OK
>> +&cpu0 {
>> + clock-frequency = <1464000000>;
>
> not sure I understand the reasoning here.
> There seems to be a regulator defined, so the cpu cores should
> have operating points defined to allow them to switch between
> different frequencies as needed.
I added the clock-frequency property to quell the following messages:
[ 0.003273] /cpus/cpu@f00 missing clock-frequency property
[ 0.003323] /cpus/cpu@f01 missing clock-frequency property
[ 0.003352] /cpus/cpu@f02 missing clock-frequency property
[ 0.003382] /cpus/cpu@f03 missing clock-frequency property
I think they are from parse_dt_topology() in arch/arm/kernel/topology.c
What do you suggest?
Regards
Justin
prev parent reply other threads:[~2019-07-26 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-16 20:47 [PATCH] ARM: dts: add device tree for Mecer Xtreme Mini S6 Justin Swartz
2019-07-25 22:19 ` Heiko Stuebner
2019-07-26 9:14 ` Justin Swartz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509782f4ece936f5ac7d0abffbd555fc@risingedge.co.za \
--to=justin.swartz@risingedge.co.za \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox