From: Jens Axboe <jaxboe@fusionio.com>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>
Subject: Re: [GIT PULL] 4 fixes for drbd
Date: Mon, 5 Nov 2012 15:43:28 +0100 [thread overview]
Message-ID: <5097D090.1000208@fusionio.com> (raw)
In-Reply-To: <1433815.PN8uhmSntl@fat-tyre>
On 2012-11-05 15:35, Philipp Reisner wrote:
>>
>> Can you rebase this against for-3.8/drivers? Thanks.
>
> Hi Jens,
>
> One of these changes fixes a regression that was introduced in the last
> merge window. Please consider to pull this single commit.
> (I will rebase the other 3 commit on for-3.8/drivers)
>
>
> The following changes since commit a13c29ddf73d3be4fbb2b1bbced64014986cd87a:
> Jens Axboe (1):
> Merge branch 'for-jens' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/linux-block into for-3.7/drivers
>
> are available in the git repository at:
>
> git://git.drbd.org/linux-drbd.git for-jens
>
> Lars Ellenberg (1):
> drbd: fix regression: potential NULL pointer dereference
>
> drivers/block/drbd/drbd_int.h | 5 +++++
> drivers/block/drbd/drbd_main.c | 8 ++++++--
> 2 files changed, 11 insertions(+), 2 deletions(-)
Sure, of course I'll take a regression fix. But the fix does not apply
to current tree:
axboe@nelson:/src/linux-block $ patch -p1 --dry-run < ~/1.txt
patching file drivers/block/drbd/drbd_int.h
Hunk #1 FAILED at 2545.
1 out of 1 hunk FAILED -- saving rejects to file drivers/block/drbd/drbd_int.h.rej
patching file drivers/block/drbd/drbd_main.c
Hunk #1 FAILED at 4232.
1 out of 1 hunk FAILED -- saving rejects to file drivers/block/drbd/drbd_main
Regression fixes for the current tree should be based on the current
tree, looks like you used an outdated for-3.7/drivers branch and this
fix depends on other fixes.
--
Jens Axboe
next prev parent reply other threads:[~2012-11-05 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 14:48 [GIT PULL] 4 fixes for drbd Philipp Reisner
2012-11-01 10:06 ` Jens Axboe
2012-11-05 14:35 ` Philipp Reisner
2012-11-05 14:43 ` Jens Axboe [this message]
2012-11-05 15:28 ` Philipp Reisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5097D090.1000208@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox