From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Irina Tirdea <irina.tirdea@gmail.com>
Subject: Re: [PATCH 3/3] perf report: Postpone objdump check until annotation requested
Date: Mon, 05 Nov 2012 08:25:35 -0700 [thread overview]
Message-ID: <5097DA6F.9000501@gmail.com> (raw)
In-Reply-To: <1351835406-15208-3-git-send-email-namhyung@kernel.org>
On 11/1/12 11:50 PM, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> David reported that current perf report refused to run on a data file
> captured from a different machine because of objdump. Since the
> objdump tools won't be used unless annotation was requested, checking
> its presence at init time doens't make sense.
>
> Reported-by: David Ahern <dsahern@gmail.com>
> Cc: Irina Tirdea <irina.tirdea@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/builtin-report.c | 9 ++-------
> tools/perf/builtin-top.c | 3 ++-
> tools/perf/ui/browsers/hists.c | 22 ++++++++++++++++------
> tools/perf/util/hist.h | 7 +++++--
> 4 files changed, 25 insertions(+), 16 deletions(-)
Reviewed-by/Tested-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2012-11-05 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 5:50 [PATCH RESEND 1/3] perf tools: Use normalized arch name for searching objdump path Namhyung Kim
2012-11-02 5:50 ` [PATCH 2/3] perf tools: Introduce struct hist_browser_timer Namhyung Kim
2012-11-05 15:25 ` David Ahern
2012-11-14 7:23 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-11-02 5:50 ` [PATCH 3/3] perf report: Postpone objdump check until annotation requested Namhyung Kim
2012-11-05 15:25 ` David Ahern [this message]
2012-11-14 7:24 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-11-05 15:25 ` [PATCH RESEND 1/3] perf tools: Use normalized arch name for searching objdump path David Ahern
2012-11-14 7:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5097DA6F.9000501@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=irina.tirdea@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox