On 2012-11-06 19:21, Chuansheng Liu wrote: > > The return value of wait_for_completion_timeout() is always >> = 0 with unsigned int type. > > So the condition "ret < 0" or "ret >= 0" is pointless. > > Signed-off-by: liu chuansheng > --- > drivers/video/omap2/dss/dispc.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c > index b43477a..9858869 100644 > --- a/drivers/video/omap2/dss/dispc.c > +++ b/drivers/video/omap2/dss/dispc.c > @@ -3893,9 +3893,6 @@ int omap_dispc_wait_for_irq_timeout(u32 irqmask, unsigned long timeout) > if (timeout == 0) > return -ETIMEDOUT; > > - if (timeout == -ERESTARTSYS) > - return -ERESTARTSYS; > - > return 0; > } Thanks. I'll apply this to omapdss tree to avoid any conflicts. Tomi