From: Jens Axboe <axboe@kernel.dk>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: smani@micron.com, yongjun_wei@trendmicro.com.cn,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mtip32xx: fix potential NULL pointer dereference in mtip_timeout_function()
Date: Thu, 08 Nov 2012 12:51:30 +0100 [thread overview]
Message-ID: <509B9CC2.4070502@kernel.dk> (raw)
In-Reply-To: <CAPgLHd96n4i905x6WdYtKM5wkSGo7V+zLKzE1mjCXBJ2v6-EbA@mail.gmail.com>
On 2012-11-08 10:35, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The dereference to port should be moved below the NULL test.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
Thanks, it definitely doesn't make sense to check for !port after having
dereferenced it. Applied.
--
Jens Axboe
prev parent reply other threads:[~2012-11-08 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 9:35 [PATCH -next] mtip32xx: fix potential NULL pointer dereference in mtip_timeout_function() Wei Yongjun
2012-11-08 11:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509B9CC2.4070502@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=smani@micron.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox