From: Pedro Alves <palves@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Amnon Shiloh <u3557@miso.sublimeip.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Serge Hallyn <serge.hallyn@canonical.com>,
Chris Evans <scarybeasts@gmail.com>,
David Howells <dhowells@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
u3557@dialix.com.au, security@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: PT_EXITKILL (Was: pdeath_signal)
Date: Thu, 08 Nov 2012 12:16:48 +0000 [thread overview]
Message-ID: <509BA2B0.2080204@redhat.com> (raw)
In-Reply-To: <20121107150934.GA27606@redhat.com>
On 11/07/2012 03:09 PM, Oleg Nesterov wrote:
>> > > > > What I would IDEALLY like to have is a call, probably a ptrace option,
>> > > > > where the parent can request: "If I am ever to terminate or be killed,
>> > > > > then my ptraced son MUST die as well".
>> > >
>> > > Perhaps this makes sense...
>> > >
>> > > Chris, iirc you also suggested something like this? And the patch is
>> > > trivial.
(...)
> OK. Please see the untested/uncompiled (but trivial) patch below
>
> - it adds PTRACE_O_EXITKILL. A better name?
>
> - A better numeric value? Note that the new option is not equal to
> the last-ptrace-option << 1. Because currently all options have
> the event, and the new one starts the eventless group. 1 << 16
> means we have the room for 8 more events.
>
> - it needs the convincing changelog for akpm
If this isn't inherited by the ptrace child's children, a fork child can
end up detached if the tracer dies before it had a chance of setting
the PTRACE_O_EXITKILL on the new auto-attached child.
Which sounds like another argument for PTRACE_O_INHERIT, as in:
http://sourceware.org/ml/archer/2011-q1/msg00026.html
(it sounds like you need to use PTRACE_SEIZE+options too to plug
the race between PTRACE_ME/PTRACE_ATTACH and
setting PTRACE_SETOPTIONS).
(For completeness, Windows' age old equivalent,
DebugSetProcessKillOnExit, it a tracer option, not tracee option, though
that's not as flexible.)
--
Pedro Alves
next prev parent reply other threads:[~2012-11-08 12:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121106152050.GA18218@sergelap>
[not found] ` <20121106201428.9D72959201A@miso.sublimeip.com>
2012-11-07 15:09 ` PT_EXITKILL (Was: pdeath_signal) Oleg Nesterov
2012-11-08 6:29 ` Amnon Shiloh
2012-11-08 12:37 ` Oleg Nesterov
2012-11-08 13:03 ` Amnon Shiloh
2012-11-18 20:21 ` [PATCH 0/1] ptrace: introduce PTRACE_O_EXITKILL Oleg Nesterov
2012-11-18 20:21 ` [PATCH 1/1] " Oleg Nesterov
2012-11-08 12:48 ` PF_NO_SIGSTOP (Was: PT_EXITKILL) Oleg Nesterov
2012-11-08 14:05 ` Amnon Shiloh
2012-11-08 12:16 ` Pedro Alves [this message]
2012-11-08 12:44 ` PT_EXITKILL (Was: pdeath_signal) Oleg Nesterov
2012-11-08 13:00 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509BA2B0.2080204@redhat.com \
--to=palves@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=scarybeasts@gmail.com \
--cc=security@kernel.org \
--cc=serge.hallyn@canonical.com \
--cc=u3557@dialix.com.au \
--cc=u3557@miso.sublimeip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).