From: Jiri Slaby <jslaby@suse.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
jirislaby@gmail.com
Subject: Re: [PATCH] HID: microsoft, do not use compound literal
Date: Mon, 12 Nov 2012 13:35:21 +0100 [thread overview]
Message-ID: <50A0ED09.6010106@suse.cz> (raw)
In-Reply-To: <CAMuHMdWq9S9oO+2OH6oiAogFR+JJxnxrtGoMp+uMm-qXCLr55A@mail.gmail.com>
On 11/12/2012 01:30 PM, Geert Uytterhoeven wrote:
> My comment was purely cosmetic, as it applies to the quoted compiler error
> messages only.
Ah, I see. When you are applying the patch Jiri, could you remove errors
about line 50 from the commit log? What I wanted to have there
apparently was only "hid-microsoft.c:51:18: error: macro "memcmp" passed
6 arguments, but takes just 3".
> Your latest version doesn't use memcmp() anymore, so I think there's no need to
> include <linux/string.h> anymore.
s/Your/His/ perhaps :). Otherwise I'd be confused -- did Jiri send some
other version?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2012-11-12 12:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 9:16 [PATCH] HID: microsoft, do not use compound literal Jiri Slaby
2012-11-12 9:23 ` Geert Uytterhoeven
2012-11-12 12:15 ` Jiri Kosina
2012-11-12 12:30 ` Geert Uytterhoeven
2012-11-12 12:35 ` Jiri Slaby [this message]
2012-11-12 12:42 ` Geert Uytterhoeven
2012-11-12 14:46 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A0ED09.6010106@suse.cz \
--to=jslaby@suse.cz \
--cc=geert@linux-m68k.org \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox