Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

Grant Likely
2012-11-12T13:01:49Z

On Mon, Nov 12, 2012 at 11:34 AM, Pantelis Antoniou
<panto@antoniou-consulting.com> wrote:
> Hi Grant,
>
> On Nov 9, 2012, at 10:33 PM, Grant Likely wrote:
>
>> On Wed, Nov 7, 2012 at 11:02 AM, Pantelis Antoniou
>> <panto@antoniou-consulting.com> wrote:
>>> On Nov 7, 2012, at 11:19 AM, Benoit Cousson wrote:
>>>> Maybe some extra version match table can just be passed during the board machine_init
>>>>
>>>> of_platform_populate(NULL, omap_dt_match_table, NULL, NULL, panda_version_match_table);
>>>>
>>>
>>> Would we need explicit of_platform_populate calls if we have node modification notifiers?
>>> In that case the notifier would pick it up automatically, and can do the per
>>> version matching internally.
>>
>> There still needs to be something to register "everything below this
>> node is interesting" which is exactly what of_platform_populate() does
>> now. I see the notifiers being used by the of_platform_populate
>> backend to know when nodes have been created (or destroyed).
>>
>> g.
>
> I see. So of_platform_populate could just register the notifier and
> not do the tree walk itself. Perhaps the name is a bit misleading then?

Kind of, yes. of_platform_populate() would still have the same effect
that it does now except that it would also pay attention to additions
and removals from the DT nodes it is interested in. This would work
cleanly enough for node additions/removals, but it wouldn't process
changes to properties on existing nodes.

g.