From: Randy Dunlap <rdunlap@infradead.org>
To: frank.rowand@am.sony.com
Cc: Thiago Farina <tfransosi@gmail.com>,
linux list <linux-kernel@vger.kernel.org>
Subject: Re: acked-by meaning
Date: Tue, 13 Nov 2012 14:31:48 -0800 [thread overview]
Message-ID: <50A2CA54.9050000@infradead.org> (raw)
In-Reply-To: <50A2C5C3.8040804@am.sony.com>
On 11/13/2012 02:12 PM, Frank Rowand wrote:
> On 11/11/12 19:47, Randy Dunlap wrote:
>> On 11/11/2012 05:40 PM, Thiago Farina wrote:
>>
>>> Hi,
>>>
>>> What is the meaning of 'Acked-by:' line? Is the same of LGTM? How it
>>> differs from 'Reviewed-by:'?
>>
>
>> Reviewed-by: is stronger than Acked-by:.
>> If someone replies with Reviewed-by, they also accept some
>> responsibility for fixing any problems that the patch might
>> introduce after it is merged.
>
> I haven't found a "responsibility for fixing any problems" in the
> references provided below. Can you help me out by pointing
> to a specific sentence or another reference?
Nope, I just recall it from the mailing list discussions
several years ago.
>> Acked-by just means agreement with the patch.
>>
>>> If someone acks a patch (can anybody acks or just the maintainer?),
>>> does it mean that he will also apply the patch to his tree?
>>
>>
>> Anybody can reply to a patch with Acked-by.
>> No, it doesn't mean that the replying/acking person will apply
>> the patch to any tree.
>>
>>
>> Have you read what Documentation/SubmittingPatches and
>> Documentation/development-process/5.Posting and 6.Followthrough
>> say about Acked-by?
>
> Thanks...
>
> -Frank
>
--
~Randy
next prev parent reply other threads:[~2012-11-13 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 1:40 acked-by meaning Thiago Farina
2012-11-12 3:47 ` Randy Dunlap
2012-11-13 22:12 ` Frank Rowand
2012-11-13 22:31 ` Randy Dunlap [this message]
2012-11-13 22:38 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A2CA54.9050000@infradead.org \
--to=rdunlap@infradead.org \
--cc=frank.rowand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox