linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* mtip32xx: Fix padding issue
       [not found] <50A397DD.4060207@micron.com>
@ 2012-11-14 13:16 ` Selvan Mani
  2012-11-14 15:36   ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Selvan Mani @ 2012-11-14 13:16 UTC (permalink / raw)
  To: axboe; +Cc: sbradshaw, asamymuthupa, linux-kernel

Hi Jens,

Another tiny patch.

Removed __packed before the struct smart_attr and added __packed at end of 
the structure to fix padding issue.

Signed-off-by: Selvan Mani  <smani@micron.com>
Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
---
 drivers/block/mtip32xx/mtip32xx.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.h b/drivers/block/mtip32xx/mtip32xx.h
index 5f4a917..1e5b1d3 100644
--- a/drivers/block/mtip32xx/mtip32xx.h
+++ b/drivers/block/mtip32xx/mtip32xx.h
@@ -155,14 +155,14 @@ enum {
 	MTIP_DDF_REBUILD_FAILED_BIT = 8,
 };
 
-__packed struct smart_attr{
+struct smart_attr {
 	u8 attr_id;
 	u16 flags;
 	u8 cur;
 	u8 worst;
 	u32 data;
 	u8 res[3];
-};
+} __packed;
 
 /* Register Frame Information Structure (FIS), host to device. */
 struct host_to_dev_fis {
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: mtip32xx: Fix padding issue
  2012-11-14 13:16 ` mtip32xx: Fix padding issue Selvan Mani
@ 2012-11-14 15:36   ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2012-11-14 15:36 UTC (permalink / raw)
  To: Selvan Mani; +Cc: sbradshaw, asamymuthupa, linux-kernel

On 2012-11-14 06:16, Selvan Mani wrote:
> Hi Jens,
> 
> Another tiny patch.
> 
> Removed __packed before the struct smart_attr and added __packed at end of 
> the structure to fix padding issue.

Thanks, applied.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-11-14 15:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <50A397DD.4060207@micron.com>
2012-11-14 13:16 ` mtip32xx: Fix padding issue Selvan Mani
2012-11-14 15:36   ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).