From: Richard Retanubun <richardretanubun@ruggedcom.com>
To: Johan Hovold <jhovold@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
Tang Nguyen <TangNguyen@ruggedcom.com>,
linux-usb mailing list <linux-usb@vger.kernel.org>
Subject: Re: kmemleak report on isp1763 and sierra MC8705
Date: Wed, 14 Nov 2012 12:12:01 -0500 [thread overview]
Message-ID: <50A3D0E1.4060209@ruggedcom.com> (raw)
In-Reply-To: <CAMgPeKUPeJSKas2VOqbG+Nt5MOtdA3jUUCsFwUcDVhwDJJCr6A@mail.gmail.com>
On 10/11/12 09:30 AM, Johan Hovold wrote:
Hi Johan,
> There was a reference-count fix for the probe error path that went in to
> v3.5. Haven't read all the details on how you trigger your leak, but at
> the face of it, it could be related.
>
> Have a look at 0658a3366db7e27fa ("usb: use usb_serial_put in
> usb_serial_probe errors). If related, you should be seeing "Ignoring
> blacklisted interface #n" messages when you enable debug (e.g. #define
> DEBUG) in the sierra driver.
That was it! Thanks so much for the research.
I can apply it cleanly to 3.0.22 and see usb_release_dev() being called and thus no more kmemleak.
>
> Greg, it seems to me that the fix referred to above should be backported
> to the earlier stable trees either way.
I would vote "yes" for this also.
While my setup circumstances may be a corner case, (modem kept resetting to re-establish PPP connection)
it was leaking 1192 bytes per occurrence.
Thanks for everyone's time.
-- Richard Retanubun.
next prev parent reply other threads:[~2012-11-14 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 21:57 kmemleak report on isp1763 and sierra MC8705 Richard Retanubun
2012-10-26 23:35 ` Greg KH
2012-10-29 20:47 ` Richard Retanubun
2012-10-29 21:11 ` Greg KH
2012-10-29 22:14 ` Alan Stern
2012-11-09 22:14 ` Richard Retanubun
2012-11-10 14:30 ` Johan Hovold
2012-11-14 17:12 ` Richard Retanubun [this message]
2012-11-14 17:52 ` Johan Hovold
2012-11-21 1:15 ` Greg Kroah-Hartman
2012-11-25 14:24 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A3D0E1.4060209@ruggedcom.com \
--to=richardretanubun@ruggedcom.com \
--cc=TangNguyen@ruggedcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).