From: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [ANNOUNCE] 3.6.6-rt17
Date: Thu, 15 Nov 2012 16:46:25 -0800 [thread overview]
Message-ID: <50A58CE1.3000000@ccrma.stanford.edu> (raw)
In-Reply-To: <alpine.LFD.2.02.1211151901300.2701@ionos>
On 11/15/2012 10:11 AM, Thomas Gleixner wrote:
> On Wed, 14 Nov 2012, Fernando Lopez-Lezcano wrote:
>
>> On 11/12/2012 01:28 PM, Thomas Gleixner wrote:
>>> Dear RT Folks,
>>>
>>> I'm pleased to announce the 3.6.6-rt17 release. 3.6.6-rt16 is just a
>>> not announced update release to 3.6.6.
>>
>> Got this:
>>
>> ----
>> net/nfc/llcp/llcp.c: In function 'nfc_llcp_register_device':
>> net/nfc/llcp/llcp.c:1185:24: error: expected expression before '{' token
>> net/nfc/llcp/llcp.c:1186:35: error: expected expression before '{' token
>> ----
>>
>> when building with CONFIG_NFC / CONFIG_NFS_LLCP (builds fine when those are
>> not set)
>
> Grrr. Damned ignorants.
>
> Does that fix it for you ?
Yes, thanks! I had to tweak the patch but it does make the whole thing
compile.
-- Fernando
> ------------>
>
> Subject: nfc: Use proper lock init functions
> From: Thomas Gleixner<tglx@linutronix.de>
> Date: Thu, 15 Nov 2012 19:03:20 +0100
>
> Grmbl. Why insist people on using static initializers if there are
> proper init functions? Just because they can?
>
> Signed-off-by: Thomas Gleixner<tglx@linutronix.de>
> ---
> net/nfc/llcp/llcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-stable/net/nfc/llcp/llcp.c
> ===================================================================
> --- linux-stable.orig/net/nfc/llcp/llcp.c
> +++ linux-stable/net/nfc/llcp/llcp.c
> @@ -1182,8 +1182,8 @@ int nfc_llcp_register_device(struct nfc_
> goto err_rx_wq;
> }
>
> - local->sockets.lock = __RW_LOCK_UNLOCKED(local->sockets.lock);
> - local->connecting_sockets.lock = __RW_LOCK_UNLOCKED(local->connecting_sockets.lock);
> + rwlock_init(&local->sockets.lock);
> + rwlock_init(&local->connecting_sockets.lock);
>
> nfc_llcp_build_gb(local);
>
next prev parent reply other threads:[~2012-11-16 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 21:28 [ANNOUNCE] 3.6.6-rt17 Thomas Gleixner
2012-11-14 19:56 ` Fernando Lopez-Lezcano
2012-11-15 14:06 ` Paul Gortmaker
2012-11-15 18:11 ` Thomas Gleixner
2012-11-16 0:46 ` Fernando Lopez-Lezcano [this message]
2012-12-21 11:06 ` Mike Galbraith
2012-12-21 14:23 ` Thomas Gleixner
2012-12-21 15:49 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A58CE1.3000000@ccrma.stanford.edu \
--to=nando@ccrma.stanford.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).