public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Mark Langsdorf <mark.langsdorf@calxeda.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Jeff Garzik <jgarzik@redhat.com>
Subject: Re: [PATCH 7/8] ata: highbank: mark ahci_highbank_probe as __devinit
Date: Thu, 15 Nov 2012 23:44:55 -0500	[thread overview]
Message-ID: <50A5C4C7.4090309@pobox.com> (raw)
In-Reply-To: <1352238933-4886-8-git-send-email-arnd@arndb.de>

On 11/06/2012 04:55 PM, Arnd Bergmann wrote:
> The ahci_highbank_probe function is incorrectly marked as __init,
> which means it can get discarded at boot time, which might be
> a problem if for some reason the device only becomes operational
> after loading another module.
>
> Using __devinit instead avoids seeing this warning for every build:
>
> WARNING: vmlinux.o(.data+0xf7b0): Section mismatch in reference from the
> variable ahci_highbank_driver to the function .init.text:ahci_highbank_probe()
> The variable ahci_highbank_driver references
> the function __init ahci_highbank_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Mark Langsdorf <mark.langsdorf@calxeda.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Jeff Garzik <jgarzik@redhat.com>
> ---
>   drivers/ata/sata_highbank.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

applied



  reply	other threads:[~2012-11-16  4:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 21:55 [PATCH 0/8] warning fixes for v3.7-rc4 Arnd Bergmann
2012-11-06 21:55 ` [PATCH 1/8] mtd: diskonchip: don't warn about ARM architecture Arnd Bergmann
2012-11-16  8:50   ` Artem Bityutskiy
2012-11-06 21:55 ` [PATCH 2/8] mtd: diskonchip: use inline functions for DocRead/DocWrite Arnd Bergmann
2012-11-06 21:55 ` [PATCH 3/8] mtd: uninitialized variable warning in map.h Arnd Bergmann
2012-11-06 21:55 ` [PATCH 4/8] sched: warnings in kernel/sched/fair.c Arnd Bergmann
2012-11-06 21:55 ` [PATCH 5/8] mmc: dw_mmc: fix modular build for exynos back-end Arnd Bergmann
2012-11-06 22:14   ` Chris Ball
2012-11-06 21:55 ` [PATCH 6/8] mmc: dw_mmc: constify dw_mci_idmac_ops in " Arnd Bergmann
2012-11-06 22:15   ` Chris Ball
2012-11-06 21:55 ` [PATCH 7/8] ata: highbank: mark ahci_highbank_probe as __devinit Arnd Bergmann
2012-11-16  4:44   ` Jeff Garzik [this message]
2012-11-16  6:23     ` Fabio Estevam
2012-11-06 21:55 ` [PATCH 8/8] drm/exynos: don't include plat/gpio-cfg.h Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A5C4C7.4090309@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=arnd@arndb.de \
    --cc=jgarzik@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.langsdorf@calxeda.com \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox