From: Shan Wei <shanwei88@gmail.com>
To: paulmck@linux.vnet.ibm.com
Cc: Shan Wei <shanwei88@gmail.com>,
dipankar@in.ibm.com,
Kernel-Maillist <linux-kernel@vger.kernel.org>,
cl@linux-foundation.org, Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH v3 6/9] rcu: use __this_cpu_read helper instead of per_cpu_ptr(p, raw_smp_processor_id())
Date: Fri, 16 Nov 2012 16:32:50 +0800 [thread overview]
Message-ID: <50A5FA32.4000903@gmail.com> (raw)
In-Reply-To: <50A1A7E8.4010802@gmail.com>
Shan Wei said, at 2012/11/13 9:52:
> From: Shan Wei <davidshan@tencent.com>
>
> Signed-off-by: Shan Wei <davidshan@tencent.com>
> Acked-by: Christoph Lameter <cl@linux.com>
Paul, would you like to pick it up to your tree?
> ---
> no changes vs v3,v2.
> ---
> kernel/rcutree.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/rcutree.c b/kernel/rcutree.c
> index 74df86b..441b945 100644
> --- a/kernel/rcutree.c
> +++ b/kernel/rcutree.c
> @@ -1960,7 +1960,7 @@ static void force_quiescent_state(struct rcu_state *rsp)
> struct rcu_node *rnp_old = NULL;
>
> /* Funnel through hierarchy to reduce memory contention. */
> - rnp = per_cpu_ptr(rsp->rda, raw_smp_processor_id())->mynode;
> + rnp = __this_cpu_read(rsp->rda->mynode);
> for (; rnp != NULL; rnp = rnp->parent) {
> ret = (ACCESS_ONCE(rsp->gp_flags) & RCU_GP_FLAG_FQS) ||
> !raw_spin_trylock(&rnp->fqslock);
>
next prev parent reply other threads:[~2012-11-16 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 1:52 [PATCH v3 6/9] rcu: use __this_cpu_read helper instead of per_cpu_ptr(p, raw_smp_processor_id()) Shan Wei
2012-11-16 8:32 ` Shan Wei [this message]
2012-11-16 16:43 ` Paul E. McKenney
2012-11-16 17:42 ` Christoph Lameter
2012-11-16 18:09 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2012-11-09 2:21 Shan Wei
2012-11-09 20:14 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A5FA32.4000903@gmail.com \
--to=shanwei88@gmail.com \
--cc=cl@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox