From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863Ab2KPNH7 (ORCPT ); Fri, 16 Nov 2012 08:07:59 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:44641 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530Ab2KPNH6 (ORCPT ); Fri, 16 Nov 2012 08:07:58 -0500 Message-ID: <50A63A5E.50409@mvista.com> Date: Fri, 16 Nov 2012 17:06:38 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Kishon Vijay Abraham I CC: balbi@ti.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers References: <1353069901-19217-1-git-send-email-kishon@ti.com> In-Reply-To: <1353069901-19217-1-git-send-email-kishon@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 16-11-2012 16:45, Kishon Vijay Abraham I wrote: > commit 392142 (moved event buffer allocation out of dwc3_core_init()). But The actual summary is "usb: dwc3: core: move event buffer allocation out of dwc3_core_init()". > event buffer allocation uses the cached copy of hwparams to determine > the number of event buffers and the caching is done in dwc3_core_init. > So moved dwc3_cache_hwparams function before dwc3_alloc_event_buffers so > that dwc3_alloc_event_buffers sees the correct number of event buffers. > Signed-off-by: Kishon Vijay Abraham I > Signed-off-by: Felipe Balbi WBR, Sergei