From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH 8/9] x86: ramdisk info print with high bits.
Date: Fri, 16 Nov 2012 08:05:33 -0800 [thread overview]
Message-ID: <50A6644D.80205@zytor.com> (raw)
In-Reply-To: <1353055989-31939-9-git-send-email-yinghai@kernel.org>
On 11/16/2012 12:53 AM, Yinghai Lu wrote:
> ramdisk could be loaded high now for 64bit.
>
> So need to print more digits for them.
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> Cc: Matt Fleming <matt.fleming@intel.com>
> ---
> arch/x86/kernel/setup.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index c2eb535..0e13c6e 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -341,7 +341,7 @@ static void __init relocate_initrd(void)
> memblock_reserve(ramdisk_here, area_size);
> initrd_start = ramdisk_here + PAGE_OFFSET;
> initrd_end = initrd_start + ramdisk_size;
> - printk(KERN_INFO "Allocated new RAMDISK: [mem %#010llx-%#010llx]\n",
> + printk(KERN_INFO "Allocated new RAMDISK: [mem %#018llx-%#018llx]\n",
> ramdisk_here, ramdisk_here + ramdisk_size - 1);
NAK, this is expected to match the resource print format (%pR), which
prints 10 digits by default and then expands. Furthermore, printing
*18* digits is downright silly since we still don't have 72-bit addressing.
-hpa
next prev parent reply other threads:[~2012-11-16 16:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 8:53 [PATCH 0/9] x86, boot, 64bit: Add support for loading ramdisk and bzImage high Yinghai Lu
2012-11-16 8:53 ` [PATCH 1/9] x86, boot: Move lldt/ltr out of 64bit only path Yinghai Lu
2012-11-16 15:55 ` H. Peter Anvin
2012-11-16 18:15 ` Yinghai Lu
2012-11-16 8:53 ` [PATCH 2/9] x86: Add macro for 64bit entry for bzImage Yinghai Lu
2012-11-16 15:56 ` H. Peter Anvin
2012-11-16 8:53 ` [PATCH 3/9] x86, 64bit: set extra ident page table for whole kernel range Yinghai Lu
2012-11-16 8:53 ` [PATCH 4/9] x86, 64bit: add support for loading kernel above 512G Yinghai Lu
2012-11-16 8:53 ` [PATCH 5/9] x86: Merge early_reserve_initrd for 32bit and 64bit Yinghai Lu
2012-11-16 8:53 ` [PATCH 6/9] x86: add get_ramdisk_image/size Yinghai Lu
2012-11-16 8:53 ` [PATCH 7/9] x86, boot: add field to support load bzImage and ramdisk high Yinghai Lu
2012-11-16 8:53 ` [PATCH 8/9] x86: ramdisk info print with high bits Yinghai Lu
2012-11-16 16:05 ` H. Peter Anvin [this message]
2012-11-16 19:21 ` Yinghai Lu
2012-11-16 19:32 ` Yinghai Lu
2012-11-16 19:39 ` H. Peter Anvin
2012-11-20 1:38 ` Valdis.Kletnieks
2012-11-16 19:39 ` H. Peter Anvin
2012-11-16 19:59 ` Yinghai Lu
2012-11-16 20:08 ` H. Peter Anvin
2012-11-16 20:12 ` Yinghai Lu
2012-11-16 20:25 ` H. Peter Anvin
2012-11-16 20:40 ` Yinghai Lu
2012-11-16 8:53 ` [PATCH 9/9] x86: remove 1024g limitation for kexec buffer on 64bit Yinghai Lu
2012-11-16 16:17 ` [PATCH 0/9] x86, boot, 64bit: Add support for loading ramdisk and bzImage high H. Peter Anvin
2012-11-17 0:40 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A6644D.80205@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox