From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Zhang <markz@nvidia.com>
Cc: airlied@redhat.com, thierry.reding@avionic-design.de,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] drm: Add NVIDIA Tegra30 support
Date: Fri, 16 Nov 2012 09:43:41 -0700 [thread overview]
Message-ID: <50A66D3D.4040708@wwwdotorg.org> (raw)
In-Reply-To: <1353041889-3114-1-git-send-email-markz@nvidia.com>
On 11/15/2012 09:58 PM, Mark Zhang wrote:
> This patch is based on Thierry's drm patch for Tegra20:
> - [PATCH v2 0/6] Device tree updates for host1x support
> - [PATCH v3 0/2] NVIDIA Tegra DRM driver
> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> index 216cd0f..6e9f1b4 100644
> --- a/drivers/gpu/drm/tegra/dc.c
> +++ b/drivers/gpu/drm/tegra/dc.c
> @@ -819,6 +819,7 @@ static int tegra_dc_remove(struct platform_device *pdev)
>
> static struct of_device_id tegra_dc_of_match[] = {
> { .compatible = "nvidia,tegra20-dc", },
> + { .compatible = "nvidia,tegra30-dc", },
The Tegra30 entries should come first in the table due to the order the
kernel (currently) matches compatible properties against theses tables.
The same comment applies for all 3 tables.
With the patch manually applied (due to the whitespace issues I
mentioned earlier), and this ordering issue fixed,
Tested-by: Stephen Warren <swarren@nvidia.com>
(On Cardhu, with no HDMI plugged in; see my next email for details).
prev parent reply other threads:[~2012-11-16 16:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 4:58 [PATCH] drm: Add NVIDIA Tegra30 support Mark Zhang
2012-11-16 6:43 ` Thierry Reding
2012-11-16 6:48 ` Mark Zhang
2012-11-16 7:11 ` Thierry Reding
2012-11-16 7:15 ` Mark Zhang
2012-11-16 16:29 ` Stephen Warren
2012-11-19 6:18 ` Mark Zhang
2012-11-19 6:45 ` Thierry Reding
2012-11-19 7:17 ` Mark Zhang
2012-11-16 16:43 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A66D3D.4040708@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=markz@nvidia.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).