Re: [PATCH 8/9] x86: ramdisk info print with high bits.

Valdis.Kletnieks
2012-11-20T01:38:28Z

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

On Fri, 16 Nov 2012 11:32:50 -0800, Yinghai Lu said:
> On Fri, Nov 16, 2012 at 11:21 AM, Yinghai Lu <yinghai@kernel.org> wrote:

> > or you prefer to cast them to pointer and use %pR for them all?
> >
> > or fix printk to add extra 2 for "0x" when # is found?
>
> looks like we have lots of %#010llx or %#010Lx there in arch/x86.
>
> We need to fix printk to make it acting like %pR ?

I'd prefer fixing the code to use %pR - when I'm looking at the code,
that tells me more about the intended semantics than $# does.

But I'm basically just a crash test dummy here - the x86 maintainers
of course get to make the decision what they'd prefer to have.

[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]