* [PATCH] kbuild: Unbreak cleaning external module build directory
@ 2012-11-18 15:01 Bart Van Assche
2012-12-09 15:07 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Bart Van Assche @ 2012-11-18 15:01 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Arnaud Lacombe, Nick Bowler, Richard Weinberger, Michal Marek,
linux-kernel
Avoid that "$(MAKE) -C $(KDIR) M=$(PWD) clean" triggers the following
error message when invoked from inside the Makefile of an external
kernel module:
rm: cannot remove 'System.map': Permission denied
make[1]: *** [clean] Error 1
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Arnaud Lacombe <lacombar@gmail.com>
Cc: Nick Bowler <nbowler@elliptictech.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Michal Marek <mmarek@suse.cz>
Cc: <stable@vger.kernel.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 9f6ca12..46b9be5 100644
--- a/Makefile
+++ b/Makefile
@@ -1252,7 +1252,7 @@ scripts: ;
endif # KBUILD_EXTMOD
clean: $(clean-dirs)
- $(Q)$(CONFIG_SHELL) $(srctree)/scripts/link-vmlinux.sh clean
+ $(Q)$(if $(KBUILD_EXTMOD),,$(CONFIG_SHELL) $(srctree)/scripts/link-vmlinux.sh clean)
$(call cmd,rmdirs)
$(call cmd,rmfiles)
@find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: Unbreak cleaning external module build directory
2012-11-18 15:01 [PATCH] kbuild: Unbreak cleaning external module build directory Bart Van Assche
@ 2012-12-09 15:07 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2012-12-09 15:07 UTC (permalink / raw)
To: Bart Van Assche
Cc: Sam Ravnborg, Arnaud Lacombe, Nick Bowler, Richard Weinberger,
linux-kernel
On 18.11.2012 16:01, Bart Van Assche wrote:
> Avoid that "$(MAKE) -C $(KDIR) M=$(PWD) clean" triggers the following
> error message when invoked from inside the Makefile of an external
> kernel module:
>
> rm: cannot remove 'System.map': Permission denied
> make[1]: *** [clean] Error 1
I just applied an earlier patch to fix this:
https://patchwork.kernel.org/patch/1663011/
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-09 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-18 15:01 [PATCH] kbuild: Unbreak cleaning external module build directory Bart Van Assche
2012-12-09 15:07 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).