From: Daniel Wagner <wagi@monom.org>
To: Tejun Heo <tj@kernel.org>
Cc: serge.hallyn@canonical.com, ebiederm@xmission.com,
nhorman@tuxdriver.com, tgraf@suug.ch, davem@davemloft.net,
lizefan@huawei.com, cgroups@vger.kernel.org,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] netcls_cgroup: implement proper hierarchy support
Date: Mon, 19 Nov 2012 14:47:06 +0100 [thread overview]
Message-ID: <50AA385A.90503@monom.org> (raw)
In-Reply-To: <1353123062-23193-4-git-send-email-tj@kernel.org>
Hi Tejun,
On 17.11.2012 04:31, Tejun Heo wrote:
> @@ -112,15 +161,6 @@ struct cgroup_subsys net_cls_subsys = {
> .subsys_id = net_cls_subsys_id,
> .base_cftypes = ss_files,
> .module = THIS_MODULE,
> -
> - /*
> - * While net_cls cgroup has the rudimentary hierarchy support of
> - * inheriting the parent's classid on cgroup creation, it doesn't
> - * properly propagates config changes in ancestors to their
> - * descendents. A child should follow the parent's configuration
> - * but be allowed to override it. Fix it and remove the following.
> - */
> - .broken_hierarchy = true,
> };
Are you sure you want to set the default to false at this point?
cheers,
daniel
next prev parent reply other threads:[~2012-11-19 13:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 3:30 [PATCHSET cgroup/for-3.8] netcls_cgroup: implement hierarchy support Tejun Heo
2012-11-17 3:31 ` [PATCH 1/3] netcls_cgroup: introduce netcls_mutex Tejun Heo
2012-11-19 14:01 ` Daniel Wagner
2012-11-17 3:31 ` [PATCH 2/3] netcls_cgroup: introduce cgroup_cls_state->is_local Tejun Heo
2012-11-19 12:54 ` Daniel Wagner
2012-11-19 17:30 ` [PATCH v2 " Tejun Heo
2012-11-19 19:18 ` Daniel Wagner
2012-11-17 3:31 ` [PATCH 3/3] netcls_cgroup: implement proper hierarchy support Tejun Heo
2012-11-19 13:47 ` Daniel Wagner [this message]
2012-11-19 17:08 ` Tejun Heo
2012-11-19 19:17 ` Daniel Wagner
2012-11-18 3:04 ` [PATCHSET cgroup/for-3.8] netcls_cgroup: implement " David Miller
2012-11-18 14:25 ` Tejun Heo
2012-11-19 13:59 ` Daniel Wagner
2012-11-19 19:01 ` Tejun Heo
2012-11-19 15:07 ` Neil Horman
2012-11-19 19:21 ` Tejun Heo
2012-11-20 5:44 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AA385A.90503@monom.org \
--to=wagi@monom.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=nhorman@tuxdriver.com \
--cc=serge.hallyn@canonical.com \
--cc=tgraf@suug.ch \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).