From: Michal Marek <mmarek@suse.cz>
To: Nicolas Palix <nicolas.palix@imag.fr>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr
Subject: Re: [PATCH] Coccicheck: Improvement for online checking with 'make C=[12]'
Date: Tue, 20 Nov 2012 10:58:58 +0100 [thread overview]
Message-ID: <50AB5462.9030401@suse.cz> (raw)
In-Reply-To: <1350031730-20822-1-git-send-email-nicolas.palix@imag.fr>
Hi Nicolas,
sorry for the delay.
On 12.10.2012 10:48, Nicolas Palix wrote:
> + # The ignore_unknown_options flag requires Coccinelle >= 0.2.3
> + FLAGS="-ignore_unknown_options -very_quiet"
> + if [ "$KBUILD_EXTMOD" = "" ] ; then
> + OPTIONS="-dir $srctree $*"
Why is -Iinclude not needed in this case?
> + else
> + OPTIONS="-dir $KBUILD_EXTMOD -patch $srctree -I $srctree/include -I $KBUILD_EXTMOD/include $*"
> + fi
The main Makefile exports the $LINUXINCLUDE variable, which contains all
the needed -I options. It would be cleaner to use that instead.
Michal
prev parent reply other threads:[~2012-11-20 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 8:48 [PATCH] Coccicheck: Improvement for online checking with 'make C=[12]' Nicolas Palix
2012-11-20 9:58 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB5462.9030401@suse.cz \
--to=mmarek@suse.cz \
--cc=Julia.Lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox