Re: [PATCH] Coccicheck: Improvement for online checking with 'make C=[12]'

Michal Marek
2012-11-20T09:59:06Z

Hi Nicolas,

sorry for the delay.

On 12.10.2012 10:48, Nicolas Palix wrote:
> + # The ignore_unknown_options flag requires Coccinelle >= 0.2.3
> + FLAGS="-ignore_unknown_options -very_quiet"
> + if [ "$KBUILD_EXTMOD" = "" ] ; then
> + OPTIONS="-dir $srctree $*"

Why is -Iinclude not needed in this case?

> + else
> + OPTIONS="-dir $KBUILD_EXTMOD -patch $srctree -I $srctree/include -I $KBUILD_EXTMOD/include $*"
> + fi

The main Makefile exports the $LINUXINCLUDE variable, which contains all
the needed -I options. It would be cleaner to use that instead.

Michal