From: Daniel Wagner <wagi@monom.org>
To: Tejun Heo <tj@kernel.org>
Cc: serge.hallyn@canonical.com, ebiederm@xmission.com,
nhorman@tuxdriver.com, tgraf@suug.ch, davem@davemloft.net,
lizefan@huawei.com, cgroups@vger.kernel.org,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 7/7] netprio_cgroup: allow nesting and inherit config on cgroup creation
Date: Tue, 20 Nov 2012 16:10:46 +0100 [thread overview]
Message-ID: <50AB9D76.3010809@monom.org> (raw)
In-Reply-To: <20121120144036.GP15971@htj.dyndns.org>
Hi Tejun,
On 20.11.2012 15:40, Tejun Heo wrote:
> Hello, Daniel.
>
> On Tue, Nov 20, 2012 at 09:57:14AM +0100, Daniel Wagner wrote:
>>> -static void cgrp_css_free(struct cgroup *cgrp)
>>> +static int cgrp_css_online(struct cgroup *cgrp)
>>> {
>>> - struct cgroup_netprio_state *cs = cgrp_netprio_state(cgrp);
>>> + struct cgroup *parent = cgrp->parent;
>>> struct net_device *dev;
>>> + int ret = 0;
>>> +
>>> + if (!parent)
>>> + return 0;
>>
>> BTW, parent is always != NULL, because the root cgroup will be
>> attached to the dummytop cgroup.
>
> Hmmm? I'm confused. When ->css_online() is called for dummytop in
> cgroup_init_subsys(), its parent is NULL. What am I missing?
Forget my comment, I was really confused when writing this. I was
looking only at cgroups which were created after bootup.
cheers,
daniel
next prev parent reply other threads:[~2012-11-20 15:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 8:30 [PATCHSET REPOST v2 cgroup/for-3.8] netcls/prio_cgroup: update hierarchy support Tejun Heo
2012-11-20 8:30 ` [PATCH 1/7] netcls_cgroup: move config inheritance to ->css_online() and remove .broken_hierarchy marking Tejun Heo
2012-11-20 8:35 ` Daniel Wagner
2012-11-20 8:30 ` [PATCH 2/7] netprio_cgroup: simplify write_priomap() Tejun Heo
2012-11-20 8:37 ` Daniel Wagner
2012-11-20 8:30 ` [PATCH 3/7] netprio_cgroup: shorten variable names in extend_netdev_table() Tejun Heo
2012-11-20 8:37 ` Daniel Wagner
2012-11-20 8:30 ` [PATCH 4/7] netprio_cgroup: reimplement priomap expansion Tejun Heo
2012-11-20 8:46 ` Daniel Wagner
2012-11-20 14:38 ` Tejun Heo
2012-11-20 15:09 ` Daniel Wagner
2012-11-20 15:13 ` Tejun Heo
2012-11-20 15:16 ` Daniel Wagner
2012-11-20 8:30 ` [PATCH 5/7] netprio_cgroup: use cgroup->id instead of cgroup_netprio_state->prioidx Tejun Heo
2012-11-20 8:47 ` Daniel Wagner
2012-11-20 8:30 ` [PATCH 6/7] netprio_cgroup: implement netprio[_set]_prio() helpers Tejun Heo
2012-11-20 8:52 ` Daniel Wagner
2012-11-20 8:30 ` [PATCH 7/7] netprio_cgroup: allow nesting and inherit config on cgroup creation Tejun Heo
2012-11-20 8:57 ` Daniel Wagner
2012-11-20 14:40 ` Tejun Heo
2012-11-20 15:10 ` Daniel Wagner [this message]
2012-11-20 18:37 ` [PATCHSET REPOST v2 cgroup/for-3.8] netcls/prio_cgroup: update hierarchy support David Miller
2012-11-22 15:33 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2012-11-20 7:06 [PATCHSET " Tejun Heo
2012-11-20 7:06 ` [PATCH 7/7] netprio_cgroup: allow nesting and inherit config on cgroup creation Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB9D76.3010809@monom.org \
--to=wagi@monom.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=serge.hallyn@canonical.com \
--cc=tgraf@suug.ch \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox