Re: [PATCH] gpiolib: let gpiochip_add_pin_range() specify offset

Linus Walleij
2012-11-20T12:57:29Z

On Tue, Nov 20, 2012 at 1:55 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 20 November 2012 17:15, Linus Walleij <linus.walleij@stericsson.com> wrote:
>> From: Linus Walleij <linus.walleij@linaro.org>
>>
>> Like with commit 3c739ad0df5eb41cd7adad879eda6aa09879eb76
>> it is not always enough to specify all the pins of a gpio_chip
>> from offset zero to be added to a pin map range, since the
>> mapping from GPIO to pin controller may not be linear at all,
>> but need to be broken into a few consecutive sub-ranges or
>> 1-pin entries for complicated cases. The ranges may also be
>> sparse.
>>
>> This alters the signature of the function to accept offsets
>> into both the GPIO-chip local pinspace and the pin controller
>> local pinspace.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Aren't there any users of this routine?

No so I'm trying to use it right now and have to fix it up :-)

I just only got Shiraz to create it to handle non-DT devices...

Will spin a V2 by the way..

Yours,
Linus Walleij