From: Rupesh Gujare <rgujare@ozmodevices.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <devel@driverdev.osuosl.org>, <sachin.kamat@linaro.org>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c
Date: Wed, 21 Nov 2012 13:42:44 +0000 [thread overview]
Message-ID: <50ACDA54.7040508@ozmodevices.com> (raw)
In-Reply-To: <20121121130527.GH11248@mwanda>
On 21/11/12 13:05, Dan Carpenter wrote:
> On Wed, Nov 21, 2012 at 12:46:15PM +0000, Rupesh Gujare wrote:
>> Call kfree only if required else return from function.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com>
> I'm not sure this is right.
>
> Signed-off-by is intended to have a legal meaning that you are
> signing off that you have permission to submit the patch. You're
> not allowed to sign off on behalf of someone else.
>
> If we apply this as is, then you get the author credit. If you want
> to give Sachin author credit then make the first line of the email:
>
> From: Sachin Kamat <sachin.kamat@linaro.org>
All right, thats my mistake. I did not understood "signed-off-by"
properly . All my intention was to acknowledge original author's
contribution and make changes which are good for driver code. I am more
than happy to resend this patch series if I am allowed to use someone
else credentials (which I felt is wrong)
Please let me know what is a best way to do it.
>
> Also it's not a good idea to get too control freaky over this code
> which is all going to have to be replaced before this can graduate
> out of staging. You're just going to discourage people from
> contributing if you redo all their patches. Linaro people are the
> real deal and you should let them help.
>
>
Only intention to redo this patch series is that, new code implemented
seems more logical to me. I welcome any criticism of code, & I am very
much happy to accept any contributions, as done in past.
--
Regards,
Rupesh Gujare
next prev parent reply other threads:[~2012-11-21 13:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121120163513.GC4990@kroah.com>
2012-11-21 12:46 ` [V2 PATCH 0/3] staging : ozwpan: Remove NULL pointer check Rupesh Gujare
2012-11-21 12:46 ` [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c Rupesh Gujare
2012-11-21 13:05 ` Dan Carpenter
2012-11-21 13:42 ` Rupesh Gujare [this message]
2012-11-21 16:19 ` Dan Carpenter
2012-11-21 17:26 ` Rupesh Gujare
2012-11-21 21:48 ` Greg KH
2012-11-21 23:10 ` Rupesh Gujare
2012-11-21 23:14 ` Greg KH
2012-11-21 12:46 ` [V2 PATCH 2/3] staging: ozwpan: Remove redundant null check before kfree in ozproto.c Rupesh Gujare
2012-11-21 12:46 ` [V2 PATCH 3/3] staging: ozwpan: Remove redundant null check before kfree in ozhcd.c Rupesh Gujare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ACDA54.7040508@ozmodevices.com \
--to=rgujare@ozmodevices.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox