Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

Greg KH
2012-11-22T21:43:29Z

On Wed, Nov 21, 2012 at 11:10:12PM +0000, Rupesh Gujare wrote:
> On 21/11/12 21:48, Greg KH wrote:
> >On Wed, Nov 21, 2012 at 05:26:12PM +0000, Rupesh Gujare wrote:
> >>On 21/11/12 16:19, Dan Carpenter wrote:
> >>>When someone sends a patch there are a several possible responses:
> >>>1) Ack the patch.
> >>>2) Request that the submitter redo it. The downside is that no one
> >>> likes redoing patches.
> >>>3) Reject the patch.
> >>>4) Redo it yourself and say "Based on a patch from Sachin Kamat".
> >>> This isn't nice because everyone wants author credit.
> >>>5) Redo it and get permission from the original author to give them
> >>> author credit get their signed-off-by.
> >>>
> >>>
> >>Thanks Dan
> >>
> >>I will keep it in mind in future.
> >>
> >>Sachin,
> >>
> >>Are you interested in redoing (or sending sign-off ?) for this patch
> >>series ? I am more than happy to accept either.
> >Don't worry, I'll clean up the mess here...
> >
> >
> Sorry Greg,
>
> But looks like you applied V1 of this patch series, rather than V2.
> Is that intentional ?

Yes.

You got the authorship version wrong on your set of patches, so I took
V1 which correctly handled it.

And, I commented on your one different patch. Please resend anything,
based on the patches I took, if you want to see them done differently.

thanks,

greg k-h