Re: [V2 PATCH 1/3] staging: ozwpan: Remove redundant null check before kfree in ozpd.c

Rupesh Gujare
2012-11-21T13:43:03Z

On 21/11/12 13:05, Dan Carpenter wrote:
> On Wed, Nov 21, 2012 at 12:46:15PM +0000, Rupesh Gujare wrote:
>> Call kfree only if required else return from function.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Signed-off-by: Rupesh Gujare <rgujare@ozmodevices.com>
> I'm not sure this is right.
>
> Signed-off-by is intended to have a legal meaning that you are
> signing off that you have permission to submit the patch. You're
> not allowed to sign off on behalf of someone else.
>
> If we apply this as is, then you get the author credit. If you want
> to give Sachin author credit then make the first line of the email:
>
> From: Sachin Kamat <sachin.kamat@linaro.org>

All right, thats my mistake. I did not understood "signed-off-by"
properly . All my intention was to acknowledge original author's
contribution and make changes which are good for driver code. I am more
than happy to resend this patch series if I am allowed to use someone
else credentials (which I felt is wrong)

Please let me know what is a best way to do it.

>
> Also it's not a good idea to get too control freaky over this code
> which is all going to have to be replaced before this can graduate
> out of staging. You're just going to discourage people from
> contributing if you redo all their patches. Linaro people are the
> real deal and you should let them help.
>
>

Only intention to redo this patch series is that, new code implemented
seems more logical to me. I welcome any criticism of code, & I am very
much happy to accept any contributions, as done in past.

--
Regards,
Rupesh Gujare